From: Jason <jason@lakedaemon.net>
To: arnd@arndb.de
Cc: grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org,
michael@walle.cc, linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL v3] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt
Date: Mon, 5 Mar 2012 08:32:42 -0500 [thread overview]
Message-ID: <20120305133242.GD5050@titan.lakedaemon.net> (raw)
In-Reply-To: <20120305034113.GB5050@titan.lakedaemon.net>
On Sun, Mar 04, 2012 at 10:41:13PM -0500, Jason Cooper wrote:
> rtc-mv: more accurate compatible strings
> orion-wdt: more accurate compatible strings
...
> arch/arm/boot/dts/kirkwood-dreamplug.dts | 34 +++++++++++++++
> arch/arm/boot/dts/kirkwood.dtsi | 12 +++++
This is still bugging me. If, say, orion_wdt.c is common to all of
plat-orion/ shouldn't it be in an 'orion.dtsi'? With compatible =
"marvell,orion-wdt"? Then, if hypothetically, kirkwood used the same
driver but had a small tweak, then kirkwood.dtsi would have
"marvell,kirkwood-wdt"? Which would let the driver know that it needed
to apply the tweak because it was kirkwood.
In this scenario, since kirkwood and dreamplug currently need no
modifications to the default wdt driver, they would just inherit
orion.dtsi's "marvell,orion-wdt", right?
On the driver side, since it currently has no subarch or board specific
tweaks, then it is *only* good for the generic case,
"marvell,orion-wdt", and thus should only match it for now.
If the above is correct, then I should create orion.dtsi, which is
included by kirkwood.dtsi. orion.dtsi should hold "marvell,orion-wdt"
and "marvell,orion-rtc". The corresponding drivers should only match
those generic strings, since there are no specific tweaks.
I hate to keep kicking this horse, but I want to make sure I grok it.
thx,
Jason.
next prev parent reply other threads:[~2012-03-05 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 3:41 [GIT PULL v3] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt Jason Cooper
2012-03-05 13:32 ` Jason [this message]
[not found] ` <20120305133242.GD5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-05 14:34 ` Arnd Bergmann
[not found] ` <201203051434.35132.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-05 14:51 ` Jason
-- strict thread matches above, loose matches on Subject: below --
2012-03-05 14:16 Andrew Lunn
2012-03-05 14:38 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305133242.GD5050@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox