From: Arnd Bergmann <arnd@arndb.de>
To: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: grant.likely@secretlab.ca, eric.y.miao@gmail.com,
devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/7] i2c: pxa: add OF support
Date: Mon, 5 Mar 2012 14:41:26 +0000 [thread overview]
Message-ID: <201203051441.26774.arnd@arndb.de> (raw)
In-Reply-To: <1330950111-30797-4-git-send-email-haojian.zhuang@marvell.com>
On Monday 05 March 2012, Haojian Zhuang wrote:
> Append these properties in below.
> mrvl,i2c-polling
> mrvl,i2c-fast-mode
>
> Still keep slave, slave_addr and class in platform data.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Just one tiny detail:
> + *i2c_types = (u32)(of_id->data);
By convention, please use (unsigned long) as the cast from pointer to an
integer type. While this doesn't make any difference on 32 bit systems,
it's better to always write code that is 64-bit clean.
Arnd
next prev parent reply other threads:[~2012-03-05 14:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 12:21 [PATCH v2 0/7] ARM: mmp: support OF on pxa168 Haojian Zhuang
[not found] ` <1330950111-30797-1-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 12:21 ` [PATCH v2 1/7] serial: pxa: add OF support Haojian Zhuang
[not found] ` <1330950111-30797-2-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 12:55 ` Arnd Bergmann
[not found] ` <201203051255.37311.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-05 14:03 ` Haojian Zhuang
2012-03-06 2:42 ` [PATCH v3 " Haojian Zhuang
[not found] ` <1331001730-13429-1-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-06 15:02 ` Arnd Bergmann
[not found] ` <201203061502.08097.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-06 15:04 ` Haojian Zhuang
2012-03-07 1:42 ` [PATCH v3 1/6] " Haojian Zhuang
[not found] ` <1331084525-4638-1-git-send-email-haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-07 7:58 ` Arnd Bergmann
2012-03-09 15:24 ` [PATCH v2 1/7] " Grant Likely
2012-04-03 15:45 ` Grant Likely
2012-03-05 12:21 ` [PATCH v2 2/7] rtc: sa1100: " Haojian Zhuang
2012-03-05 14:41 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 3/7] i2c: pxa: " Haojian Zhuang
2012-03-05 14:41 ` Arnd Bergmann [this message]
2012-03-05 12:21 ` [PATCH v2 4/7] ARM: mmp: enable rtc clk in pxa168 Haojian Zhuang
[not found] ` <1330950111-30797-5-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 14:38 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 5/7] ARM: mmp: append OF support on pxa168 Haojian Zhuang
[not found] ` <1330950111-30797-6-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 14:37 ` Arnd Bergmann
2012-04-09 1:36 ` Chris Ball
[not found] ` <87y5q5znx8.fsf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
2012-04-09 1:46 ` Haojian Zhuang
[not found] ` <CAN1soZyXH_fpwOdDESB600MAm0FL_aanhnVKaLke0O+6B_v9dg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-09 1:51 ` Chris Ball
[not found] ` <87hawtzn8z.fsf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
2012-04-09 2:04 ` Haojian Zhuang
2012-04-09 1:43 ` Chris Ball
[not found] ` <87ty0tznlb.fsf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
2012-04-09 1:47 ` Haojian Zhuang
2012-03-05 12:21 ` [PATCH v2 6/7] ARM: dts: append DTS file of pxa168 Haojian Zhuang
[not found] ` <1330950111-30797-7-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 14:35 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 7/7] Document: devicetree: add OF documents for arch-mmp Haojian Zhuang
[not found] ` <1330950111-30797-8-git-send-email-haojian.zhuang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2012-03-05 14:46 ` Arnd Bergmann
2012-03-05 15:07 ` Rob Herring
2012-03-05 15:08 ` Cousson, Benoit
2012-04-02 23:21 ` Mitch Bradley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203051441.26774.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).