From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Subject: Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree. Date: Wed, 7 Mar 2012 13:37:05 -0500 Message-ID: <20120307183705.GC5050@titan.lakedaemon.net> References: <80fb8cef577eee14364e95009f7a590fd9056ee3.1331090356.git.jason@lakedaemon.net> <201203071831.31738.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201203071831.31738.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Arnd Bergmann Cc: nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, michael-QKn5cuLxLXY@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Mar 07, 2012 at 06:31:31PM +0000, Arnd Bergmann wrote: > On Wednesday 07 March 2012, Jason Cooper wrote: > > + serial@f1012000 { > > + compatible = "ns16550a"; > > + reg = <0xf1012000 0xff>; > > + reg-shift = <2>; > > + interrupts = <33>; > > + clock-frequency = <200000000>; > > + }; > > I just noticed that the length here should be inclusive, i.e. 0x100 not 0xff. > This is different from the way we define resources in Linux. I was maintaining form with plat-orion/common.c:66 (0xff) I'll fix it to inclusive. thx, Jason.