From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
andrew-g2DYL2Zd6BY@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
michael-QKn5cuLxLXY@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 14/14] ARM: kirkwood: use devicetree to init sata_mv
Date: Wed, 7 Mar 2012 18:40:09 +0000 [thread overview]
Message-ID: <201203071840.09572.arnd@arndb.de> (raw)
In-Reply-To: <8503a766f6f75c9acf49abd66d9cdce54807b2b2.1331090356.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
On Wednesday 07 March 2012, Jason Cooper wrote:
> @@ -504,6 +504,16 @@ static int __init kirkwood_clock_gate(void)
> kirkwood_clk_ctrl |= CGC_USB0;
> of_node_put(np);
> }
> +
> + np = of_find_compatible_node(NULL, NULL, "mrvl,orion-sata");
> + if (np && of_device_is_available(np)) {
> + int nr_ports;
> + kirkwood_clk_ctrl |= CGC_SATA0;
> + of_property_read_u32(np, "nr-ports", &nr_ports);
> + if (nr_ports > 1)
> + kirkwood_clk_ctrl |= CGC_SATA1;
> + of_node_put(np);
> + }
> #endif
>
> /* For SATA: first shutdown the phy */
Is it guaranteed that it's always the first port that gets used if there
is only one? If not, this might turn on the wrong one.
Arnd
next prev parent reply other threads:[~2012-03-07 18:40 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 18:20 [PATCH 0/4] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt Jason Cooper
2012-03-01 18:20 ` [PATCH 1/4] ARM: kirkwood: move var setting to correct location Jason Cooper
2012-03-01 18:20 ` [PATCH 2/4] ARM: kirkwood: fdt: absorb kirkwood_init() Jason Cooper
[not found] ` <9d9a87361c05b8b85e1ee2cdabb46a365c7abca8.1330625877.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-02 7:09 ` Grant Likely
2012-03-01 18:20 ` [PATCH 3/4] ARM: kirkwood: convert rtc-mv to fdt Jason Cooper
[not found] ` <2c985a303f3b9b0cfcead25634b7e1db68d34ee3.1330625878.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-01 19:35 ` Arnd Bergmann
[not found] ` <201203011935.58503.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-01 21:26 ` Jason
2012-03-02 7:19 ` Grant Likely
2012-03-02 9:48 ` Arnd Bergmann
2012-03-02 16:27 ` Jason
2012-03-04 14:59 ` Michael Walle
2012-03-04 16:48 ` Arnd Bergmann
[not found] ` <201203041648.17428.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-04 22:27 ` Jason
2012-03-04 23:22 ` Michael Walle
2012-03-01 18:20 ` [PATCH 4/4] ARM: kirkwood: convert orion-wdt " Jason Cooper
[not found] ` <2f29e88b98b2bcff0c241996e6d7216a60995d2d.1330625878.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-01 19:48 ` Arnd Bergmann
2012-03-02 7:22 ` Grant Likely
2012-03-02 9:15 ` Simon Guinot
[not found] ` <20120302091510.GC29461-tZfvYpCFA3RN6yImKYG91Q@public.gmane.org>
2012-03-02 14:15 ` Jason
[not found] ` <20120302141541.GE11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 14:56 ` Arnd Bergmann
2012-03-02 15:36 ` Jason
2012-03-02 16:48 ` Arnd Bergmann
2012-03-02 17:02 ` Jason
[not found] ` <20120302170252.GJ11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 22:36 ` Andrew Lunn
[not found] ` <20120302223629.GA21080-g2DYL2Zd6BY@public.gmane.org>
2012-03-03 22:54 ` Jason
2012-03-01 19:50 ` [PATCH 0/4] ARM: kirkwood: fdt: convert kirkwood init funcs " Arnd Bergmann
[not found] ` <201203011950.51210.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-01 20:01 ` Jason
2012-03-01 20:28 ` Arnd Bergmann
[not found] ` <201203012028.04773.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-01 21:23 ` Jason
[not found] ` <20120301212353.GC11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-01 22:14 ` Arnd Bergmann
2012-03-02 16:31 ` Jason
[not found] ` <20120302163121.GI11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 16:58 ` Arnd Bergmann
2012-03-02 17:04 ` Jason
2012-03-07 3:44 ` [PATCH 0/14 v3] ARM: kirkwood: fdt: convert kirkwood " Jason Cooper
2012-03-07 3:44 ` [PATCH 03/14] ARM: kirkwood: add dreamplug (fdt) support Jason Cooper
[not found] ` <cover.1330625877.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-02 17:50 ` [PATCH 0/5 v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt Jason Cooper
[not found] ` <cover.1330709314.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-02 17:50 ` [PATCH 1/5 v2] ARM: kirkwood: covert orion-spi " Jason Cooper
2012-03-04 18:12 ` Michael Walle
[not found] ` <201203041912.21137.michael-QKn5cuLxLXY@public.gmane.org>
2012-03-04 20:29 ` Arnd Bergmann
2012-03-02 17:52 ` [PULL REQUEST] ARM: kirkwood: fdt: convert kirkwood init funcs " Jason
[not found] ` <20120302175233.GM11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 17:56 ` Jason
2012-03-02 17:50 ` [PATCH 2/5] ARM: kirkwood: move var setting to correct location Jason Cooper
2012-03-02 17:50 ` [PATCH 3/5 v2] ARM: kirkwood: fdt: absorb kirkwood_init() Jason Cooper
2012-03-02 17:50 ` [PATCH 4/5 v2] ARM: kirkwood: convert rtc-mv to fdt Jason Cooper
2012-03-04 15:12 ` Michael Walle
2012-03-04 16:50 ` Arnd Bergmann
[not found] ` <201203041650.52217.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-05 0:17 ` Jason
2012-03-02 17:50 ` [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt " Jason Cooper
[not found] ` <e2fe5e97a83fc753559bbb18d5d111ed01b89034.1330709314.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-02 18:32 ` Arnd Bergmann
[not found] ` <201203021832.34901.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-02 19:57 ` Jason
[not found] ` <20120302195710.GP11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 20:02 ` Arnd Bergmann
2012-03-02 20:00 ` [PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs " Jason
[not found] ` <20120302200034.GQ11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-02 20:35 ` Arnd Bergmann
[not found] ` <201203022035.44672.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-02 21:18 ` Arnd Bergmann
[not found] ` <201203022118.05796.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-05 18:49 ` Nicolas Pitre
[not found] ` <alpine.LFD.2.02.1203051344130.31242-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-05 19:15 ` Jason
[not found] ` <20120305191546.GK5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-05 20:16 ` Arnd Bergmann
[not found] ` <201203052016.26949.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-05 20:29 ` Jason
[not found] ` <20120305202941.GN5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-05 20:43 ` Nicolas Pitre
[not found] ` <alpine.LFD.2.02.1203051542190.31242-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-05 21:17 ` Jason
[not found] ` <20120305211737.GO5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-05 21:27 ` Nicolas Pitre
[not found] ` <alpine.LFD.2.02.1203051626370.31242-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-06 14:29 ` Jason
2012-03-03 10:08 ` [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt " Russell King - ARM Linux
[not found] ` <20120303100853.GK7363-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-03-03 23:05 ` Jason
[not found] ` <cover.1331090356.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-07 3:44 ` [PATCH 01/14] ARM: orion: spi: remove enable_clock_fix which is not used Jason Cooper
[not found] ` <b0fe0cfb7e76a869a8ba7f7344de75eb122e206c.1331090356.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-09 4:33 ` Grant Likely
2012-03-07 3:44 ` [PATCH 02/14] ARM: Kirkwood: Remove tclk from kirkwood_asoc_platform_data Jason Cooper
2012-03-07 3:44 ` [PATCH 04/14] ARM: kirkwood: fdt: absorb kirkwood_init() Jason Cooper
2012-03-07 3:44 ` [PATCH 05/14] ARM: kirkwood: add interrupt controller to devicetree Jason Cooper
2012-03-07 3:44 ` [PATCH 06/14] ARM: kirkwood: convert uart0 " Jason Cooper
2012-03-07 18:31 ` Arnd Bergmann
[not found] ` <201203071831.31738.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-07 18:37 ` Jason
2012-03-07 19:27 ` Jason
[not found] ` <20120307192723.GE5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-07 20:05 ` Andrew Lunn
[not found] ` <20120307200515.GC18513-g2DYL2Zd6BY@public.gmane.org>
2012-03-07 20:55 ` Jason
2012-03-07 21:47 ` Michael Walle
2012-03-08 21:31 ` Grant Likely
[not found] ` <20120308213139.GC16533-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-03-08 21:55 ` Jason
2012-03-07 21:13 ` Arnd Bergmann
[not found] ` <201203072113.04369.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-07 21:29 ` Jason
2012-03-08 16:25 ` Jason
[not found] ` <20120308162530.GI5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-08 17:01 ` Arnd Bergmann
[not found] ` <201203081701.01663.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-08 17:41 ` Arnd Bergmann
2012-03-08 19:27 ` Thomas Gleixner
2012-03-08 19:47 ` Jason
[not found] ` <20120308194725.GM5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-08 21:32 ` Grant Likely
2012-03-08 21:50 ` Jason
2012-03-08 22:22 ` Rob Herring
2012-03-08 21:27 ` Grant Likely
[not found] ` <20120308212701.GB16533-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-03-08 23:14 ` Arnd Bergmann
2012-03-07 3:44 ` [PATCH 07/14] ARM: kirkwood: rtc-mv devicetree bindings Jason Cooper
2012-03-07 3:44 ` [PATCH 08/14] ARM: kirkwood: use devicetree for rtc-mv Jason Cooper
[not found] ` <146e96ef8a8649767b3beb49ff39a260e75f234a.1331090356.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-07 18:32 ` Arnd Bergmann
2012-03-07 3:44 ` [PATCH 09/14] ARM: kirkwood: mv_cesa devicetree bindings Jason Cooper
2012-03-07 3:44 ` [PATCH 10/14] ARM: kirkwood: mv_cesa devicetree support Jason Cooper
2012-03-07 3:44 ` [PATCH 11/14] ARM: kirkwood: ehci-orion: add device tree binding Jason Cooper
2012-03-07 3:44 ` [PATCH 12/14] ARM: kirkwood: use devicetree for orion-ehci Jason Cooper
2012-03-07 3:44 ` [PATCH 13/14] ARM: kirkwood: sata_mv: add device tree binding Jason Cooper
2012-03-07 3:44 ` [PATCH 14/14] ARM: kirkwood: use devicetree to init sata_mv Jason Cooper
[not found] ` <8503a766f6f75c9acf49abd66d9cdce54807b2b2.1331090356.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-07 18:40 ` Arnd Bergmann [this message]
[not found] ` <201203071840.09572.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-07 18:52 ` Jason
[not found] ` <20120307185204.GD5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-07 19:00 ` Arnd Bergmann
2012-03-13 1:57 ` [PATCH 0/7 v4] ARM: kirkwood: fdt: convert kirkwood to fdt Jason Cooper
[not found] ` <cover.1331601448.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-13 1:57 ` [PATCH 3/7 v2] ARM: orion: wdt: use resource vice direct access Jason Cooper
2012-03-13 9:54 ` Arnd Bergmann
2012-03-13 1:57 ` [PATCH 4/7 v4] ARM: kirkwood: add dreamplug (fdt) support Jason Cooper
[not found] ` <0032addd7e94c5d4d1a3a0be77fe79bcffee53db.1331601448.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-13 10:10 ` Arnd Bergmann
[not found] ` <201203131010.43095.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-13 13:12 ` Jason Cooper
2012-04-05 22:07 ` Ian Campbell
[not found] ` <1333663656.12209.62.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>
2012-04-05 22:41 ` Jason Cooper
[not found] ` <20120405224143.GL817-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-04-06 8:52 ` Ian Campbell
[not found] ` <cover.1331868507.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-16 4:21 ` [PATCH 1/9] ARM: orion: spi: remove enable_clock_fix which is not used Jason Cooper
2012-03-16 20:18 ` [PATCH 0/9 v5] ARM: kirkwood: fdt: convert kirkwood to fdt Arnd Bergmann
2012-03-16 20:28 ` Jason Cooper
2012-03-16 20:41 ` Arnd Bergmann
[not found] ` <201203162041.12831.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-16 21:02 ` Jason Cooper
2012-03-13 1:57 ` [PATCH 1/7] ARM: orion: spi: remove enable_clock_fix which is not used Jason Cooper
2012-03-13 1:57 ` [PATCH 2/7] ARM: Kirkwood: Remove tclk from kirkwood_asoc_platform_data Jason Cooper
2012-03-13 1:57 ` [PATCH 5/7 v2] ARM: kirkwood: convert uart0 to devicetree Jason Cooper
[not found] ` <970083c931bbd5c58be3aa982a66fddc48ceb534.1331601448.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-13 13:18 ` Jason Cooper
2012-03-13 1:57 ` [PATCH 6/7] ARM: kirkwood: rtc-mv devicetree bindings Jason Cooper
[not found] ` <0b9921e304cb46af9c4fbc8b7b8c8b9ba3d18654.1331601448.git.jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2012-03-13 9:57 ` Arnd Bergmann
2012-03-13 10:03 ` Uwe Kleine-König
2012-03-13 1:57 ` [PATCH 7/7] ARM: kirkwood: use devicetree for rtc-mv Jason Cooper
2012-03-13 9:58 ` Arnd Bergmann
[not found] ` <201203130958.31223.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-13 13:22 ` Jason Cooper
2012-03-13 13:44 ` Arnd Bergmann
2012-03-16 4:21 ` [PATCH 0/9 v5] ARM: kirkwood: fdt: convert kirkwood to fdt Jason Cooper
2012-03-16 4:21 ` [PATCH 2/9] ARM: Kirkwood: Remove tclk from kirkwood_asoc_platform_data Jason Cooper
2012-03-16 4:21 ` [PATCH 3/9 v3] ARM: orion: wdt: use resource vice direct access Jason Cooper
2012-03-16 4:21 ` [PATCH 4/9] ARM: kirkwood: fdt: use mrvl ticker symbol Jason Cooper
2012-03-16 4:21 ` [PATCH 5/9] ARM: kirkwood: fdt: absorb kirkwood_init() Jason Cooper
2012-03-16 4:21 ` [PATCH 6/9 v2] ARM: kirkwood: fdt: facilitate new boards during fdt migration Jason Cooper
2012-03-16 4:21 ` [PATCH 7/9] ARM: kirkwood: fdt: define uart[01] as disabled, enable uart0 Jason Cooper
2012-03-16 4:21 ` [PATCH 8/9 v2] ARM: kirkwood: rtc-mv devicetree bindings Jason Cooper
2012-03-16 4:21 ` [PATCH 9/9] ARM: kirkwood: use devicetree for rtc-mv Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203071840.09572.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=michael-QKn5cuLxLXY@public.gmane.org \
--cc=nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).