From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH 1/5 v4] i2c/gpio: add DT support Date: Tue, 13 Mar 2012 17:47:56 +0100 Message-ID: <20120313164756.GF18320@game.jcrosoft.org> References: <1331642024-19869-1-git-send-email-plagnioj@jcrosoft.com> <20120313140822.GD2488@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120313140822.GD2488-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Wolfram Sang Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 15:08 Tue 13 Mar , Wolfram Sang wrote: > On Tue, Mar 13, 2012 at 01:33:40PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > update to use devm_kzalloc for private data > > Hmm, you need really to work on the commit messages, not everybody is > familiar with DT and its implications: > > "To achieve DT support, we need to populate a custom platform_data in a > private struct from DT information. To simplify code, the adapter and > algorithm are also put into the private struct." > ok I put this can I get the Ack ? I need to send the pull asap Best Regards, J.