From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v3 2/2] regulator: add device tree support for max8997 Date: Tue, 13 Mar 2012 12:18:03 -0600 Message-ID: <20120313181803.B45073E053B@localhost> References: <1330000688-11226-1-git-send-email-thomas.abraham@linaro.org> <1330000688-11226-3-git-send-email-thomas.abraham@linaro.org> <20120313034306.16CF73E07E4@localhost> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Thomas Abraham Cc: linux-kernel@vger.kernel.org, k.lewandowsk@samsung.com, devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com, kgene.kim@samsung.com, broonie@opensource.wolfsonmicro.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, dg77.kim@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Rajendra Nayak List-Id: devicetree@vger.kernel.org On Tue, 13 Mar 2012 12:14:42 +0530, Thomas Abraham wrote: > On 13 March 2012 09:13, Grant Likely wrot= e: > > On Thu, 23 Feb 2012 18:08:08 +0530, Thomas Abraham wrote: > > Otherwise, the patch looks pretty good. =C2=A0(although seeing the = decode function > > has got me thinking that we need a much better way of decoding the = dt data). >=20 > The parsing function looks huge since there is lot of data to pick up > from the dt node. Oh, I understand that you have to do it this way; I just think the core= code should make it a lot easier. :-) g.