From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: kirkwood devicetree respin Date: Tue, 20 Mar 2012 13:22:38 -0400 Message-ID: <20120320172238.GC2484@titan.lakedaemon.net> References: <20120312214325.GD5050@titan.lakedaemon.net> <201203131557.49488.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201203131557.49488.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Arnd Bergmann Cc: andrew-g2DYL2Zd6BY@public.gmane.org, Jamie Lentin , michael-QKn5cuLxLXY@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Mar 13, 2012 at 03:57:49PM +0000, Arnd Bergmann wrote: > On Monday 12 March 2012, Jason Cooper wrote: > > Only issue I have (I think unrelated) is that orion-ehci isn't coming > > up. But these patches don't touch that, so I think it might be my > > config again. Although it doesn't look like it... > > I looked at your patches but also couldn't find anything that hints > at why ehci would break. I figured it out. Apparently, dreamplug is the first board to put root on usb-attached microsd card. And I'm the first one to try to compile orion-ehci into the kernel. ;-) The following fix the problem: diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c index 6c6a5a3..0808417 100644 --- a/drivers/usb/host/ehci-orion.c +++ b/drivers/usb/host/ehci-orion.c @@ -318,3 +318,5 @@ static struct platform_driver ehci_orion_driver = { .shutdown = usb_hcd_platform_shutdown, .driver.name = "orion-ehci", }; + +module_platform_driver(ehci_orion_driver); I figure most folks will build orion-ehci as a module and use an initrd. In the meantime, I'll carry this patch in my stack for v3.5. Unless you would prefer to do something different. thx, Jason.