Re: [PATCH] USB: Add DT probing support to ehci-spear and ohci-spear

[Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>]

Hi Viresh,

On Friday 23 March 2012 04:48:05 Viresh Kumar wrote:
> On 3/22/2012 9:20 PM, Stefan Roese wrote:
> > +static struct of_device_id spear_ohci_id_table[] __devinitdata = {
> > +	{ .compatible = "st,spear600-ohci", },
> 
> Hi Stefan,
> 
> I have this question for other drivers (fsmc, stmmac...) as well:
> Why do we name it spear600-ohci and not spear-ohci?
> Because i believe we have same version of USB on all SPEAr SoCs.

There could be differences between the IP cores integrated into the SoCs. I 
only tested on spear600, so thats what I integrated into the drivers. While 
supporting more SoCs (SPEAr300 etc) to those drivers, you should add the 
specific compatible properties to the lists.

If the IP core doesn't differ between those SoCs, then it might make sense to 
change this property to something more general, like "st,spear-ohci" (etc). 
Not 100% sure though. Other DT experts might have more insight here.

Thanks,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html