From: Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] scripts: dtc: fix compile warnings
Date: Sat, 24 Mar 2012 23:13:47 +0100 [thread overview]
Message-ID: <20120324221347.GA8947@sepie.suse.cz> (raw)
In-Reply-To: <1327576807-19216-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
On Thu, Jan 26, 2012 at 01:20:07PM +0200, Felipe Balbi wrote:
> Fix following compile warnings:
>
> scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
> scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
> [-Wunused-but-set-variable]
>
> scripts/dtc/dtc.c: In function ‘main’:
> scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
This was somehow forgotten, I applied the patch to kbuild.git#kbuild now.
> ---
> scripts/dtc/dtc.c | 5 +----
> scripts/dtc/flattree.c | 2 --
> 2 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
> const char *outform = "dts";
> const char *outname = "-";
> const char *depname = NULL;
> - int force = 0, check = 0, sort = 0;
> + int force = 0, sort = 0;
> const char *arg;
> int opt;
> FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
> case 'f':
> force = 1;
> break;
> - case 'c':
> - check = 1;
> - break;
BTW, you should also remove 'c' from the getopt() string.
Michal
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2012-03-24 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 11:20 [PATCH] scripts: dtc: fix compile warnings Felipe Balbi
2012-01-26 16:58 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF178CB8233B-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-26 17:14 ` Jon Loeliger
[not found] ` <1327576807-19216-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-03-24 22:13 ` Michal Marek [this message]
2012-03-25 0:38 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324221347.GA8947@sepie.suse.cz \
--to=mmarek-alswssmvlrq@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).