From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH] fdtget-runtest.sh: Fix failures when /bin/sh isn't bash Date: Tue, 27 Mar 2012 10:37:09 +1100 Message-ID: <20120326233709.GB9357@truffala.fritz.box> References: <1332296626-19707-1-git-send-email-swarren@wwwdotorg.org> <20120321032653.GB15997@truffala.fritz.box> <20120326022350.GA13005@truffala.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jon Loeliger Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Mar 26, 2012 at 08:11:35AM -0500, Jon Loeliger wrote: > > On Wed, Mar 21, 2012 at 02:26:53PM +1100, David Gibson wrote: > > > On Tue, Mar 20, 2012 at 08:23:46PM -0600, Stephen Warren wrote: > > > > On Ubuntu, /bin/sh is dash (at least by default), and dash's echo doesn't > > > > accept the -e option. This means that fdtget-runtest.sh's EXPECT file will > > > > contain "-e foo" rather than just "foo", which causes a test failure. > > > > > > > > To work around this, run /bin/echo instead of (builtin) echo, which has > > > > more chance of supporting the -e option. > > > > > > > > Another possible fix is to change all the #! lines to /bin/bash rather > > > > than /bin/sh, and change run_tests.sh to invoke sub-scripts using $SHELL > > > > instead of just "sh". However, that would require bash specifically, which > > > > may not be desirable. > > > > > > > > Signed-off-by: Stephen Warren > > > > > > Acked-by: David Gibson > > > > > > Jon, please apply. > > > > Sorry Jon, you fell off the Cc list somehow. Do you need me to resend > > Stephen's patch to apply? > > Please. Last mail I saw on this issue was you saying "This patch > isn't perfect." :-) Uh, it was "this isn't perfect, but it's better than what we have, please apply". I've forwarded Stephen's patch to you again. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson