From: Grant Likely <grant.likely@secretlab.ca>
To: benh@kernel.crashing.org, jwboyer@gmail.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Cc: Tanmay Inamdar <tinamdar@apm.com>
Subject: Re: [PATCH 3/5] powerpc: dts: klondike: Add UART nodes
Date: Tue, 03 Apr 2012 09:57:03 -0600 [thread overview]
Message-ID: <20120403155703.3B0593E053F@localhost> (raw)
In-Reply-To: <1333348747-12713-3-git-send-email-tinamdar@apm.com>
On Mon, 2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <tinamdar@apm.com> wrote:
> Adding UART nodes in Klondike device tree file.
>
> Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
> ---
> :100644 100644 4ff2852... d5bf2e1... M arch/powerpc/boot/dts/klondike.dts
> arch/powerpc/boot/dts/klondike.dts | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
> index 4ff2852..d5bf2e1 100644
> --- a/arch/powerpc/boot/dts/klondike.dts
> +++ b/arch/powerpc/boot/dts/klondike.dts
> @@ -222,6 +222,30 @@
> #size-cells = <1>;
> ranges;
> clock-frequency = <0>;
> +
> + UART0: serial@50001000 {
> + device_type = "serial";
> + compatible = "ns16550";
> + reg = <0x50001000 0x00000100>;
> + virtual-reg = <0x50001000>;
Why do you need virtual-reg? The kernel should handle all iomapping
properly without this.
g.
next prev parent reply other threads:[~2012-04-03 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 6:39 [PATCH 1/5] powerpc: dts: klondike: Add AHB, APB bus; remove OPB bus Tanmay Inamdar
2012-04-02 6:39 ` [PATCH 2/5] powerpc: 40x: Add AHB, APB of_device_ids Tanmay Inamdar
2012-04-02 6:39 ` [PATCH 3/5] powerpc: dts: klondike: Add UART nodes Tanmay Inamdar
2012-04-02 6:39 ` [PATCH 4/5] powerpc: config: 40x: Add 16650 UART support in klondike defconfig Tanmay Inamdar
2012-04-02 6:39 ` [PATCH 5/5] powerpc: kernel: 16650 UART reg-shift support Tanmay Inamdar
2012-04-03 15:57 ` Grant Likely [this message]
2012-04-04 0:49 ` [PATCH 3/5] powerpc: dts: klondike: Add UART nodes Josh Boyer
2012-04-04 5:39 ` Tanmay Inamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403155703.3B0593E053F@localhost \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).