* Re: [PATCHv3 3/3] misc: add support for bmp18x chips to the bmp085 driver
2012-04-04 20:11 ` [PATCHv3 3/3] misc: add support for bmp18x chips to the bmp085 driver Mark Brown
@ 2012-04-05 6:53 ` Eric Andersson
2012-04-07 1:37 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Eric Andersson @ 2012-04-05 6:53 UTC (permalink / raw)
To: Mark Brown
Cc: Arnd Bergmann, linux-kernel, gregkh, alan, zhengguang.guo,
peter.moeller, stefan.nilsson, devicetree-discuss
Hi,
Thanks for the review guys!
On 21:11 Wed 04 Apr , Mark Brown wrote:
> On Wed, Apr 04, 2012 at 08:00:33PM +0000, Arnd Bergmann wrote:
> > On Wednesday 04 April 2012, Mark Brown wrote:
> > > > +static const struct of_device_id bmp085_of_match[] = {
> > > > + { .compatible = "bosch-sensortec,bmp085", },
>
> > > Traditionally the stock ticker symbol would be used.
>
> > I though about commenting on that as well, but since Bosch is a foundation
> > and not publically traded, that would be hard to accomplish. Is there
> > an official fallback for companies that don't have a stock ticker symbol?
>
> Guess we should ask the DT people... I mostly just noticed that the
> name appeared somewhat verbose - perhaps just plain "bosch" if there's
> not a better abbrevation?
If there are no further objections let's go with "bosch". I'll prepare a
new patch-set ASAP.
--
Best regards,
Eric
http://www.unixphere.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCHv3 3/3] misc: add support for bmp18x chips to the bmp085 driver
2012-04-04 20:11 ` [PATCHv3 3/3] misc: add support for bmp18x chips to the bmp085 driver Mark Brown
2012-04-05 6:53 ` Eric Andersson
@ 2012-04-07 1:37 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-04-07 1:37 UTC (permalink / raw)
To: Mark Brown, Arnd Bergmann
Cc: Eric Andersson, linux-kernel, gregkh, alan, zhengguang.guo,
peter.moeller, stefan.nilsson, devicetree-discuss
On Wed, 4 Apr 2012 21:11:17 +0100, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Apr 04, 2012 at 08:00:33PM +0000, Arnd Bergmann wrote:
> > On Wednesday 04 April 2012, Mark Brown wrote:
> > > > +static const struct of_device_id bmp085_of_match[] = {
> > > > + { .compatible = "bosch-sensortec,bmp085", },
>
> > > Traditionally the stock ticker symbol would be used.
>
> > I though about commenting on that as well, but since Bosch is a foundation
> > and not publically traded, that would be hard to accomplish. Is there
> > an official fallback for companies that don't have a stock ticker symbol?
>
> Guess we should ask the DT people... I mostly just noticed that the
> name appeared somewhat verbose - perhaps just plain "bosch" if there's
> not a better abbrevation?
*MY* official fallback is go with whatever is documented in
Documentation/devicetree/bindings/vendor-prefixes.txt. If the needed
value isn't there, then add it! :-)
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread