From: Grant Likely <grant.likely@secretlab.ca>
To: "Cousson, Benoit" <b-cousson@ti.com>,
Sourav Poddar <sourav.poddar@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data
Date: Fri, 06 Apr 2012 18:39:27 -0700 [thread overview]
Message-ID: <20120407013927.AC7163E21DC@localhost> (raw)
In-Reply-To: <4F7C51EA.1040902@ti.com>
On Wed, 4 Apr 2012 15:51:38 +0200, "Cousson, Benoit" <b-cousson@ti.com> wrote:
> On 4/4/2012 3:30 PM, Sourav Poddar wrote:
> > This patch add keypad data node in omap4 device tree
> > file.
>
> Nit #2: Never write "this patch" in a patch changelog... Because at some
> point it will become a commit in a GIT tree.
>
> I think AKPM wrote something on that.
Whatever. I'm won't *ever* get worked up about something like that if
the changelog is otherwise well written. What I do want to see is a
description of what the patch does, why it is needed, and how it was
tested.
g.
next prev parent reply other threads:[~2012-04-07 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 13:30 [PATCH 0/2] Add device tree support for omap4 keypad Sourav Poddar
2012-04-04 13:30 ` [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data Sourav Poddar
2012-04-04 13:48 ` Cousson, Benoit
2012-04-04 13:51 ` Cousson, Benoit
2012-04-07 1:39 ` Grant Likely [this message]
2012-04-04 13:30 ` [PATCH 2/2] drivers: input: keypad: Add device tree support Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120407013927.AC7163E21DC@localhost \
--to=grant.likely@secretlab.ca \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).