From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data Date: Fri, 06 Apr 2012 18:39:27 -0700 Message-ID: <20120407013927.AC7163E21DC@localhost> References: <1333546221-19700-1-git-send-email-sourav.poddar@ti.com> <1333546221-19700-2-git-send-email-sourav.poddar@ti.com> <4F7C51EA.1040902@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F7C51EA.1040902@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "Cousson, Benoit" , Sourav Poddar Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Felipe Balbi , Rob Herring , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, 4 Apr 2012 15:51:38 +0200, "Cousson, Benoit" wrote: > On 4/4/2012 3:30 PM, Sourav Poddar wrote: > > This patch add keypad data node in omap4 device tree > > file. > > Nit #2: Never write "this patch" in a patch changelog... Because at some > point it will become a commit in a GIT tree. > > I think AKPM wrote something on that. Whatever. I'm won't *ever* get worked up about something like that if the changelog is otherwise well written. What I do want to see is a description of what the patch does, why it is needed, and how it was tested. g.