From: Grant Likely <grant.likely@secretlab.ca>
To: Olof Johansson <olof@lixom.net>, Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: arnd@arndb.de, devicetree-discuss@lists.ozlabs.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ludovic.desroches@atmel.com, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 13/13] ARM: at91: dt: remove unit-address part for memory nodes
Date: Fri, 06 Apr 2012 18:43:30 -0700 [thread overview]
Message-ID: <20120407014330.B6D4E3E22DF@localhost> (raw)
In-Reply-To: <20120404191754.GE10603@quad.lixom.net>
On Wed, 4 Apr 2012 12:17:54 -0700, Olof Johansson <olof@lixom.net> wrote:
> On Tue, Apr 03, 2012 at 09:32:57AM +0200, Nicolas Ferre wrote:
> > From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> > Having a unit-address different from 0 causes bad memory node detection
> > during early_init_dt_scan_memory.
>
> Sounds like a bug in the generic code to me? But specifying a unit
> address on a non-ambiguous device node isn't necessary anyway, so this
> patch is still a reasonable thing to do.
It's actually a 'feature' of the way we're including skeleton.dtsi.
skeleton.dtsi has already set the node name, so if the next file
doesn't use exactly the same node name then the .dtb ends up with two
memory nodes, which is really bad.
It real problem is the dtc tooling.
g.
prev parent reply other threads:[~2012-04-07 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1333437885.git.nicolas.ferre@atmel.com>
[not found] ` <cover.1333437885.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-04-03 7:27 ` [PATCH v2 13/13] ARM: at91: dt: remove unit-address part for memory nodes Nicolas Ferre
[not found] ` <1db62b280314855c35cb7a3188fc9d9cb8501948.1333437885.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-04-03 15:39 ` Grant Likely
2012-04-04 19:17 ` Olof Johansson
2012-04-07 1:43 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120407014330.B6D4E3E22DF@localhost \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).