From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Date: Tue, 17 Apr 2012 14:30:06 +0200 Message-ID: <20120417123006.GC3852@pengutronix.de> References: <1334333915-1174-1-git-send-email-b29396@freescale.com> <20120414134814.GA3852@pengutronix.de> <20120415141736.GG24997@S2101-09.ap.freescale.net> <20120416034713.GB17173@shlinux2.ap.freescale.net> <20120416034646.GI24997@S2101-09.ap.freescale.net> <20120417095722.GF17173@shlinux2.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120417095722.GF17173@shlinux2.ap.freescale.net> Sender: linux-kernel-owner@vger.kernel.org To: Dong Aisheng Cc: Shawn Guo , Dong Aisheng-B29396 , Dong Aisheng , "linus.walleij@stericsson.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, Apr 17, 2012 at 05:57:23PM +0800, Dong Aisheng wrote: > Sascha & Shawn, > > Just let you know: > After changes the pinctrl table may look like: > (i also removed fsl,* config properties since it was introduced for better > readability before, but after dtc macro support is available, it could also > be removed. So i removed now. Then the using is much similar as iomux-v3). > > iomuxc@020e0000 { > compatible = "fsl,imx6q-iomuxc"; > reg = <0x020e0000 0x4000>; > > /* shared pinctrl settings */ > uart4 { > pinctrl_uart4_1: uart4grp-1 { > fsl,pins = <58 61>; > fsl,configs = <0x12407> Why do we have a hex value for the config now? This should be independent on how we describe the mux settings. Also I think a single fsl,configs entry for a pin group is not enough, what for example with I2C where the data line needs a pullup whereas the clock line does not? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |