From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Liam Girdwood <lrg@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 3/4] mfd: tps65910: Add device-tree support
Date: Thu, 19 Apr 2012 13:50:41 +0100 [thread overview]
Message-ID: <20120419125041.GH3046@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334777758.32315.37.camel@rklein-linux>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Wed, Apr 18, 2012 at 12:35:58PM -0700, Rhyland Klein wrote:
> On Wed, 2012-04-18 at 02:01 -0700, Mark Brown wrote:
> > This is a really odd idiom - normally the pattern for device tree
> > support is to just go and try to use the device tree data if it's there
> > and there's no need for any flag to say if it should be used.
> I agree its odd. My concern was that the idiom is that is pdata assigned
> from board files should override dt data. At this point, we don't know
> where the tps65910->board_data is coming from, dt or board files.
> Arbitrarily using dt breaks that idiom. We could do a check like this if
> you prefer:
No, just prefer the DT - what you're proposing is exactly the opposite
idiom to what all the other DT drivers do so we'd need to go round
changing the policy globally at which point we probably want to start
having helpers for this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-19 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 1:00 [PATCH 0/4] Update TPS65910 to boot using devicetree Rhyland Klein
2012-04-18 1:00 ` [PATCH 1/4] regulator: tps65910: update type for regmap Rhyland Klein
[not found] ` <1334710829-22777-2-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-18 9:25 ` Mark Brown
[not found] ` <20120418092547.GE3021-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-18 20:03 ` Rhyland Klein
2012-04-18 20:19 ` Rhyland Klein
2012-04-19 12:54 ` Mark Brown
2012-04-18 1:00 ` [PATCH 2/4] regulator: tps65910: Add device tree bindings Rhyland Klein
[not found] ` <1334710829-22777-3-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-18 8:35 ` Mark Brown
2012-04-18 1:00 ` [PATCH 3/4] mfd: tps65910: Add device-tree support Rhyland Klein
[not found] ` <1334710829-22777-4-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-18 9:01 ` Mark Brown
[not found] ` <20120418090133.GC3021-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-18 19:35 ` Rhyland Klein
2012-04-19 12:50 ` Mark Brown [this message]
[not found] ` <20120419125041.GH3046-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-19 15:35 ` Stephen Warren
[not found] ` <4F9030D5.2050601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-19 16:34 ` Mark Brown
[not found] ` <1334710829-22777-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-18 1:00 ` [PATCH 4/4] ARM: Tegra: Add support for TPS65910 PMIC Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419125041.GH3046@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).