From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v5] i2c: Add device tree support to i2c-pnx.c Date: Fri, 20 Apr 2012 14:09:50 +0200 Message-ID: <20120420120950.GA15613@pengutronix.de> References: <1334913755-10466-1-git-send-email-stigge@antcom.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Return-path: Content-Disposition: inline In-Reply-To: <1334913755-10466-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Stigge Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, vitalywool-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kevin.wells-3arQi8VN3Tc@public.gmane.org, srinivas.bakki-3arQi8VN3Tc@public.gmane.org List-Id: devicetree@vger.kernel.org --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 20, 2012 at 11:22:35AM +0200, Roland Stigge wrote: > This patch adds device tree support to the pnx-i2c driver by using platfo= rm > resources for memory region and irq and removing dependency on mach inclu= des. >=20 > The following platforms are affected: >=20 > * PNX > * LPC31xx (WIP) > * LPC32xx >=20 > The patch is based on a patch by Jon Smirl, working on lpc31xx integration >=20 > Signed-off-by: Roland Stigge > Reviewed-by: Arnd Bergmann > Acked-by: Wolfram Sang NACK! I said the approach of dropping "timeout" is OK, but unless I say "you may add my ack after changing this and that", please do not automatically add my ack. Doesn't hurt here, since I have to pick it up anyway. > Changes since v4: > * Removed OF timeout property (to be added later when there is consensus = about > how to call and handle it) > * Changed clock-frequency example to decimal Thanks, I just noticed. Please drop (more precise: remove) the "slave-addr" for the same reasons as "timeout". Doesn't make much sense anyhow, pnx doesn't have any slave support. > ret =3D request_irq(alg_data->irq, i2c_pnx_interrupt, > - 0, pdev->name, alg_data); > + 0, pdev->name, alg_data); I know that checkpatch complains about this, but I'd prefer to avoid such changes unless the code before was really unreadable. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+RUg4ACgkQD27XaX1/VRszjQCfZ3I5d72a7N3aTncbjFrZyxtz 8CYAoJW01IRAID0JFnc9fZuRqKqpFzKQ =qWMv -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--