Re: [PATCH 4/5] ARM: mxs: do not add dma device by default

[Dong Aisheng <aisheng.dong-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

On Mon, Apr 23, 2012 at 09:59:57AM +0800, Shawn Guo wrote:
> On Wed, Apr 18, 2012 at 08:46:36PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > 
> > This will cause conflict when dt is enabled.
> > So let each platform add dma devices respectively.
> > 
> > Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Cc: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Dong Aisheng <dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >  arch/arm/mach-mxs/devices-mx23.h                |    2 ++
> >  arch/arm/mach-mxs/devices-mx28.h                |    2 ++
> >  arch/arm/mach-mxs/devices/platform-dma.c        |    3 +--
> >  arch/arm/mach-mxs/include/mach/devices-common.h |    3 +++
> >  arch/arm/mach-mxs/mach-apx4devkit.c             |    1 +
> >  arch/arm/mach-mxs/mach-m28evk.c                 |    1 +
> >  arch/arm/mach-mxs/mach-mx23evk.c                |    1 +
> >  arch/arm/mach-mxs/mach-stmp378x_devb.c          |    1 +
> >  arch/arm/mach-mxs/mach-tx28.c                   |    1 +
> >  9 files changed, 13 insertions(+), 2 deletions(-)
> > 
> I think instead of asking every board file to add dma device
> explicitly, we probably need to do something similar to imx, having
> functions imx23_soc_init and imx28_soc_init which will only be called
> for non-dt boot, and adding devices like dma, gpio there.
> 
Yes, it's fine to me since gpio has the same issue.
Will revise the patch.

Regards
Dong Aisheng