From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, patches@linaro.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, kgene.kim@samsung.com, cjb@laptop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks
Date: Wed, 2 May 2012 10:53:11 +0100 [thread overview]
Message-ID: <20120502095311.GZ24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1335935266-25289-2-git-send-email-thomas.abraham@linaro.org>
On Tue, May 01, 2012 at 10:07:40PM -0700, Thomas Abraham wrote:
> Some platforms allow for clock gating and control of bus interface unit clock
> and card interface unit clock. Add support for clock lookup of optional biu
> and ciu clocks for clock gating and clock speed determination.
As we're moving progressively towards the common clk API, which requires
the new clk_prepare/clk_unprepare calls, new code should be using the
dated API. Please update this to do so (eg, by using clk_prepare_enable()
instead of clk_enable() for the simple solution.) Better solutions
involve decoupling the two and only using clk_enable()/clk_disable() where
you really need the clock to be on.
next prev parent reply other threads:[~2012-05-02 9:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 5:07 [PATCH 0/7] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-05-02 5:07 ` [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-05-02 9:17 ` Will Newton
2012-05-10 9:11 ` Thomas Abraham
2012-05-02 9:53 ` Russell King - ARM Linux [this message]
2012-05-10 9:12 ` Thomas Abraham
2012-05-02 14:53 ` James Hogan
2012-05-10 9:20 ` Thomas Abraham
2012-05-10 13:43 ` Russell King - ARM Linux
2012-05-02 5:07 ` [PATCH 2/7] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-05-02 9:10 ` Will Newton
2012-05-02 5:07 ` [PATCH 3/7] mmc: dw_mmc: add device tree support Thomas Abraham
2012-05-02 6:55 ` Kyungmin Park
2012-05-10 9:42 ` Thomas Abraham
[not found] ` <CAJuYYwQqPEDP3ygkjOjeAwUr--M13KSB7JdYm8Tiok5BvJbruw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-10 9:59 ` Kyungmin Park
2012-05-10 10:12 ` Thomas Abraham
2012-05-02 18:07 ` Olof Johansson
2012-05-10 10:15 ` Thomas Abraham
[not found] ` <CAJuYYwSmiPNrFhd9xr2AkAbRfJm_gP9ym+AXyy9jyPG3FnFuhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-12 7:07 ` Olof Johansson
[not found] ` <CAOesGMiXfODM=hDp9EP3uQOk041XCvPFfTzDwfkvBWeGWLdCgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-12 8:43 ` Thomas Abraham
2012-05-03 22:48 ` Guennadi Liakhovetski
2012-05-12 7:01 ` Thomas Abraham
2012-05-12 19:31 ` Guennadi Liakhovetski
2012-05-17 15:39 ` Thomas Abraham
2012-05-10 10:32 ` James Hogan
2012-05-10 10:44 ` Thomas Abraham
2012-05-02 5:07 ` [PATCH 4/7] mmc: dw_mmc: add samsung exynos5250 specific extentions Thomas Abraham
2012-05-02 7:01 ` Kyungmin Park
2012-05-02 7:49 ` Jaehoon Chung
[not found] ` <4FA0E706.8060700-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-05-10 10:55 ` Thomas Abraham
2012-05-10 11:17 ` Jaehoon Chung
2012-05-10 10:38 ` Thomas Abraham
2012-05-02 18:10 ` Olof Johansson
2012-05-10 10:55 ` Thomas Abraham
2012-05-02 5:07 ` [PATCH 5/7] ARM: Samsung: Add support for MSHC controller clocks Thomas Abraham
2012-05-02 7:04 ` Kyungmin Park
2012-05-02 5:07 ` [PATCH 6/7] ARM: Exynos5: Add AUXDATA support for MSHC controllers Thomas Abraham
2012-05-02 5:07 ` [PATCH 7/7] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502095311.GZ24211@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).