From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback Date: Mon, 21 May 2012 11:40:14 -0700 Message-ID: <20120521184014.GA21692@kroah.com> References: <1337592237-5090-1-git-send-email-richard.zhao@freescale.com> <201205211936.40359.marex@denx.de> <20120521174742.GA31739@kroah.com> <201205212032.21757.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201205212032.21757.marex-ynQEQJNshbs@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut Cc: Richard Zhao , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org, B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linuxzsc-MeMPY/F8WlbQT0dZR+AlfA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, May 21, 2012 at 08:32:21PM +0200, Marek Vasut wrote: > Dear Greg KH, > > > On Mon, May 21, 2012 at 07:36:40PM +0200, Marek Vasut wrote: > > > Dear Greg KH, > > > > > > > On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: > > > > > This let usb phy driver has a chance to change hw settings when > > > > > connect status change. > > > > > > > > > > Signed-off-by: Richard Zhao > > > > > --- > > > > > > > > > > include/linux/usb/otg.h | 13 +++++++++++++ > > > > > 1 files changed, 13 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h > > > > > index 38ab3f4..385641d 100644 > > > > > --- a/include/linux/usb/otg.h > > > > > +++ b/include/linux/usb/otg.h > > > > > @@ -117,6 +117,10 @@ struct usb_phy { > > > > > > > > > > int (*set_suspend)(struct usb_phy *x, > > > > > > > > > > int suspend); > > > > > > > > > > + /* notify phy connect status change */ > > > > > + int (*notify_connect_change)(struct usb_phy *x, > > > > > + int port, > > > > > + int connected); > > > > > > > > > > }; > > > > > > > > No, please make this two different callbacks. As you see in your code > > > > > > > > when you implemented this, you really have: > > > > if (connected) { > > > > > > > > do this... > > > > > > > > } else { > > > > > > > > do that... > > > > > > > > } > > > > > > > > So you there is no consolidation in the driver, so just make it 2 > > > > callbacks, especially as someone wanted to make connected -1 just for a > > > > tristate, which would be impossible to document properly... > > > > > > Or he could make connected an enum maybe ? > > > > No, again, that will make nothing easier on the driver end at all. > > > > What's the problem with different functions that people keep resisting? > > The structure grows a few bytes ... so the kernel eats a bit more ram. The time it took you to write this email just made up for that extra ram, sorry :) It doesn't matter, have people leaned nothing from our past mistakes? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html