From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Subject: Re: [PATCH 1/3] spi-orion: add device tree binding Date: Sun, 3 Jun 2012 23:48:49 +0200 Message-ID: <201206032348.49208.michael@walle.cc> References: <1338754678-17000-1-git-send-email-michael@walle.cc> <20120603210123.GL14756@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120603210123.GL14756-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jason Cooper Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Jason, Am Sonntag 03 Juni 2012, 23:01:23 schrieb Jason Cooper: > On Sun, Jun 03, 2012 at 10:17:56PM +0200, Michael Walle wrote: > > Signed-off-by: Michael Walle > > --- > > > > .../devicetree/bindings/spi/spi-orion.txt | 5 +++++ > > drivers/spi/spi-orion.c | 11 +++++++++++ > > 2 files changed, 16 insertions(+), 0 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/spi/spi-orion.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-orion.txt > > b/Documentation/devicetree/bindings/spi/spi-orion.txt new file mode > > 100644 > > index 0000000..e68597a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/spi-orion.txt > > @@ -0,0 +1,5 @@ > > +Marvell Orion SPI device > > + > > +Required properties: > > +- compatible : should be "marvell,orion-spi". > > The above is correct, and a change in policy from when dreamplug DT > support was first added. > > > +- reg : offset and length of the register set for the device > > diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c > > index 2760450..2de58bb 100644 > > --- a/drivers/spi/spi-orion.c > > +++ b/drivers/spi/spi-orion.c > > @@ -17,6 +17,7 @@ > > > > #include > > #include > > #include > > > > +#include > > > > #include > > #include > > > > @@ -506,6 +507,7 @@ static int __init orion_spi_probe(struct > > platform_device *pdev) > > > > if (orion_spi_reset(spi) < 0) > > > > goto out_rel_mem; > > > > + master->dev.of_node = pdev->dev.of_node; > > > > status = spi_register_master(master); > > if (status < 0) > > > > goto out_rel_mem; > > > > @@ -547,10 +549,19 @@ static int __exit orion_spi_remove(struct > > platform_device *pdev) > > > > MODULE_ALIAS("platform:" DRIVER_NAME); > > > > +#ifdef CONFIG_OF > > +static const struct of_device_id orion_spi_of_match_table[] > > __devinitdata = { + { .compatible = "mrvl,orion-spi", }, > > Please make this consistent with the documentation, "marvell,orion-spi", > thanks. That'll be one less to convert over later. oh, actually i forgot to change the documentation. wasnt the convention to use the name used in the stock exchange? eg. the nand driver uses mrvl,orion-nand, or kirkwood itself is named "mrvl,kirkwood". Or did i miss sth, because you wrote "one less to convert over later"? -- michael