From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: devicetree-discuss@lists.ozlabs.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>
Cc: kernel@pengutronix.de
Subject: [PATCH RESEND] of: add const to struct of_device_id.data
Date: Thu, 7 Jun 2012 12:20:14 +0200 [thread overview]
Message-ID: <20120607102014.GI22191@pengutronix.de> (raw)
In-Reply-To: <1335171381-24869-1-git-send-email-u.kleine-koenig@pengutronix.de>
Drivers should never need to modify the data of a device id. So it can
be const which in turn allows more consts in the driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
(Cc += lkml + Grant)
Hello,
this might introduce warnings in drivers that access the data member
without using const, so this is definitly merge window material if it is
considered at all.
Best regards
Uwe
include/linux/mod_devicetable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 501da4c..183f411 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -222,7 +222,7 @@ struct of_device_id
char type[32];
char compatible[128];
#ifdef __KERNEL__
- void *data;
+ const void *data;
#else
kernel_ulong_t data;
#endif
--
1.7.10
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-06-07 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 8:56 [PATCH] of: add const to struct of_device_id.data Uwe Kleine-König
[not found] ` <1335171381-24869-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-05-18 14:43 ` Uwe Kleine-König
2012-05-21 19:49 ` [PATCH] spi/imx: make devtype_data member point to const data Uwe Kleine-König
[not found] ` <1337629775-9166-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-22 5:50 ` Uwe Kleine-König
2012-05-21 19:54 ` [PATCH] ARM: cache-l2x0: add a const qualifier Uwe Kleine-König
2012-05-21 19:57 ` [PATCH] serial/imx: make devdata member point to const data Uwe Kleine-König
2012-06-07 10:20 ` Uwe Kleine-König [this message]
2012-06-22 5:56 ` [PATCH RESEND] of: add const to struct of_device_id.data Uwe Kleine-König
2012-06-22 17:26 ` Arnd Bergmann
2012-06-24 14:43 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607102014.GI22191@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).