From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [Patch v5 05/13] usb: otg: add basic mxs phy driver support Date: Thu, 14 Jun 2012 00:03:17 +0200 Message-ID: <20120613220317.GH30400@pengutronix.de> References: <1339590863-10564-1-git-send-email-richard.zhao@freescale.com> <1339590863-10564-6-git-send-email-richard.zhao@freescale.com> <20120613213312.GD30400@pengutronix.de> <201206132356.16093.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201206132356.16093.marex-ynQEQJNshbs@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut Cc: Richard Zhao , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org, B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, Peter Chen List-Id: devicetree@vger.kernel.org On Wed, Jun 13, 2012 at 11:56:15PM +0200, Marek Vasut wrote: > Dear Sascha Hauer, > > > > > This message is rather useless. It is really not expected for kzalloc > > to fail. If it fails here you really have problems elsewhere and this > > message won't help you debugging it. > > It's not useless, but it'll hardly ever be displayed if you run out of memory so > badly this kzalloc() will fail. If you run out of memory while allocating a few bytes it's really not interesting where exactly this happens. The message won't give you any hint where you can fix this problem. Also, if you bail out of a drivers probe function with -ENOMEM you will have a message in the log anyway. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html