Re: [Patch v5 06/13] usb: chipidea: add imx platform driver

[Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>]

Dear Sascha Hauer,

> On Wed, Jun 13, 2012 at 08:34:16PM +0800, Richard Zhao wrote:
> > This patch supports only the host-mode functionality so far.
> > 
> > Signed-off-by: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Cc: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> > Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
> > ---
> > 
> >  .../devicetree/bindings/usb/ci13xxx-imx.txt        |   20 +++
> >  drivers/usb/chipidea/Makefile                      |    3 +
> >  drivers/usb/chipidea/ci13xxx_imx.c                 |  189
> >  ++++++++++++++++++++ 3 files changed, 212 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
> >  create mode 100644 drivers/usb/chipidea/ci13xxx_imx.c
> > 

[...]

> > +
> > +	ci13xxx_imx_platdata.phy = data->phy;
> > +
> > +	if (!pdev->dev.dma_mask) {
> > +		pdev->dev.dma_mask = devm_kzalloc(&pdev->dev,
> > +				      sizeof(*pdev->dev.dma_mask), GFP_KERNEL);
> > +		if (!pdev->dev.dma_mask) {
> > +			ret = -ENOMEM;
> > +			dev_err(&pdev->dev, "Failed to alloc dma_mask!\n");
> > +			goto err;
> > +		}
> > +		*pdev->dev.dma_mask = DMA_BIT_MASK(32);
> > +		dma_set_coherent_mask(&pdev->dev, *pdev->dev.dma_mask);
> > +	}
> 
> Do you need this? I assume not.

Ain't this the dma mask crap without which the usb stuff won't work?

> Sascha

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html