From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Paul Mundt <lethal@linux-sh.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] devicetree: add helper inline for retrieving a node's full name
Date: Fri, 15 Jun 2012 22:00:28 -0600 [thread overview]
Message-ID: <20120616040028.C83513E0ACE@localhost> (raw)
In-Reply-To: <1339801070.9220.211.camel@pasglop>
On Sat, 16 Jun 2012 08:57:50 +1000, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Fri, 2012-06-15 at 11:50 -0600, Grant Likely wrote:
> > The pattern (np ? np->full_name : "<none>") is rather common in the
> > kernel, but can also make for quite long lines. This patch adds a new
> > inline function, of_node_full_name() so that the test for a valid node
> > pointer doesn't need to be open coded at all call sites.
>
> s/of_node_full_name/of_node_path ?
It would be nicer to have the shorter name, but the data member is
already named full_name, so I'd rather use the same for the function
name (unless you argue strongly against, it's not something I'm going
to fight about).
g.
next prev parent reply other threads:[~2012-06-16 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 17:50 [PATCH] devicetree: add helper inline for retrieving a node's full name Grant Likely
2012-06-15 22:57 ` Benjamin Herrenschmidt
2012-06-16 4:00 ` Grant Likely [this message]
2012-06-16 4:59 ` Benjamin Herrenschmidt
2012-07-05 16:07 ` Rob Herring
[not found] ` <4FF5BBC3.6020900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-11 13:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120616040028.C83513E0ACE@localhost \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).