devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk,
	a.p.zijlstra@chello.nl, grant.likely@secretlab.ca,
	rob.herring@calxeda.com
Subject: Re: [PATCH v2 5/5] sched: cpu_power: enable ARCH_POWER
Date: Tue, 19 Jun 2012 17:01:11 +0800	[thread overview]
Message-ID: <20120619090110.GA1692@zhy> (raw)
In-Reply-To: <1340094536-20873-6-git-send-email-vincent.guittot@linaro.org>

On Tue, Jun 19, 2012 at 10:28:56AM +0200, Vincent Guittot wrote:
> Heteregeneous ARM platform uses arch_scale_freq_power function
> to reflect the relative capacity of each core
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>  kernel/sched/features.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/features.h b/kernel/sched/features.h
> index de00a48..d98ae90 100644
> --- a/kernel/sched/features.h
> +++ b/kernel/sched/features.h
> @@ -42,7 +42,7 @@ SCHED_FEAT(CACHE_HOT_BUDDY, true)
>  /*
>   * Use arch dependent cpu power functions
>   */
> -SCHED_FEAT(ARCH_POWER, false)
> +SCHED_FEAT(ARCH_POWER, true)

Hmmm...seems we can remove this knob completely.

__weak arch_scale_smt_power() is doing all the trick.

Thanks,
Yong

  reply	other threads:[~2012-06-19  9:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  8:28 [PATCH v2 0/5] ARM: topology: set the capacity of each cores for big.LITTLE Vincent Guittot
     [not found] ` <1340094536-20873-1-git-send-email-vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-06-19  8:28   ` [PATCH v2 1/5] ARM: topology: Add arch_scale_freq_power function Vincent Guittot
2012-06-19  8:28   ` [PATCH v2 2/5] ARM: topology: factorize the update of sibling masks Vincent Guittot
2012-06-19  8:28   ` [PATCH v2 3/5] ARM: topology: Update cpu_power according to DT information Vincent Guittot
2012-06-19  8:28   ` [PATCH v2 4/5] sched, x86: Remove broken power estimation Vincent Guittot
2012-06-19  8:28   ` [PATCH v2 5/5] sched: cpu_power: enable ARCH_POWER Vincent Guittot
2012-06-19  9:01     ` Yong Zhang [this message]
2012-06-20  9:11       ` Vincent Guittot
     [not found]         ` <CAKfTPtAdSMJ1RnDPDYZZ378QW9DUCKLA+oC3TWJD7v5KAkFitA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-20  9:19           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120619090110.GA1692@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rob.herring@calxeda.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).