From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH REPOST] Add test for re-defining an identical label
Date: Sun, 8 Jul 2012 22:51:17 +1000 [thread overview]
Message-ID: <20120708125117.GA7749@truffala.fritz.box> (raw)
In-Reply-To: <1341346170-16312-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Tue, Jul 03, 2012 at 02:09:30PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> When merging one device tree over the top of a previous tree, it is
> possible to define a duplicate label that has the same name and points
> to the same property or node. This is currently allowed by the duplicate
> label checking code. However, alternative duplicate label checking
> algorithms might not allow this. Add an explicit test to ensure this
> capability is maintained.
Sorry, I've been on leave and haven't really had brainspace to think
about this. I think you're right though, whatever else we do with
stuff we do want to allow redefinition of labels as long as they
attach to the same thing (i.e. same path, and property within that
path when applicable). Labels within property values do get curly if
that property is altered, but that doesn't directly affect this test.
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-07-08 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 20:09 [PATCH REPOST] Add test for re-defining an identical label Stephen Warren
[not found] ` <1341346170-16312-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-08 12:51 ` David Gibson [this message]
[not found] ` <20120708125117.GA7749-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-07-08 18:44 ` Jon Loeliger
[not found] ` <E1SnwSi-0008Eq-OH-CYoMK+44s/E@public.gmane.org>
2012-07-08 23:42 ` David Gibson
[not found] ` <20120708234219.GD7749-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-07-09 0:05 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120708125117.GA7749@truffala.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).