From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH] mfd: add tps65910 32-kHz-crystal-input init Date: Mon, 16 Jul 2012 15:43:55 +0200 Message-ID: <20120716134355.GI20652@sortiz-mobl> References: <20120705152334.GH18200@sortiz-mobl> <1342014273-31665-1-git-send-email-jhovold@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1342014273-31665-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Johan Hovold Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org Hi Johan, On Wed, Jul 11, 2012 at 03:44:33PM +0200, Johan Hovold wrote: > Replace tps65910_misc_init with a dedicated init function for the > 32-kHz-crystal input. > > Signed-off-by: Johan Hovold > --- > > Hi Samuel, > > How about something like this? My thought with misc_init was that it could be > extended should more simple initialisation like for the ck32k_xtal need to be > done, but perhaps it's cleaner to stick with dedicated init functions > through-out. At least for now. Yes, it's clearer, at least to me. I applied this patch, thanks for following up. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/