From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [PATCH v2 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers Date: Tue, 17 Jul 2012 11:04:12 +0800 Message-ID: <20120717030411.GG19699@shlinux2.ap.freescale.net> References: <1342084080-3145-1-git-send-email-b29396@freescale.com> <20120716081703.GH21635@b20223-02.ap.freescale.net> <201207161340.18528.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201207161340.18528.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Zhao Richard-B20223 , "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Liu Hui-R64343 , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , Samuel Ortiz , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Mike Turquette List-Id: devicetree@vger.kernel.org On Mon, Jul 16, 2012 at 09:40:17PM +0800, Arnd Bergmann wrote: > On Monday 16 July 2012, Richard Zhao wrote: > > > If you really wants a "funnel driver" doing all these diverse things, > > > I'd put it in drivers/mfd. > > > > It's like driver drivers/mfd/anatop-mfd.c. They both store misc bits. > > We may need a generic driver to simply provide register accessor. > > We already have the "regmap" framework that deals with sets of registers > on spi, i2c or memory mapped buses. One thing I've thought about Thanks for the hints. Will look into it. > before is to create some kind of very simple "system controller" > framework based on regmap that lets you register a single global > "struct regmap" pointer from an SoC specific driver, and have drivers > call a function into that framework to get a reference to that > regmap. > That would be a good idea to make people easy use. Regards Dong Aisheng