From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller
Date: Fri, 20 Jul 2012 22:10:28 +0000 [thread overview]
Message-ID: <201207202210.28790.arnd@arndb.de> (raw)
In-Reply-To: <1342787373-2230-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
On Friday 20 July 2012, Tony Prisk wrote:
> Add support for a generic non-pci UHCI companion controller.
> Existing board files for arch-vt8500 updated to include UHCI
> support.
>
> Signed-off-by: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
Looks almost good, but
* please add a binding document
* cc the maintainers and usb mailing list
* the "of-uhci" string does not seem appropriate:
> +static const struct of_device_id platform_uhci_ids[] = {
> + { .compatible = "of-uhci", },
> + {}
> +};
The of- part is clearly meaningless in the binding that is about of
devices. Using usb-uhci would be more appropriate I think, but maybe
someone can come up with an even better name. Which consortium
or company created uhci?
Arnd
next prev parent reply other threads:[~2012-07-20 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 12:29 [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk
[not found] ` <1342787373-2230-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-07-20 12:29 ` [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller Tony Prisk
[not found] ` <1342787373-2230-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-07-20 22:10 ` Arnd Bergmann [this message]
[not found] ` <201207202210.28790.arnd-r2nGTMty4D4@public.gmane.org>
2012-07-21 16:19 ` Sergei Shtylyov
2012-07-20 22:05 ` [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207202210.28790.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).