Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT

[Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>]

Dear Rob Herring,

> +devicetree-discuss
> 
> On 07/22/2012 08:20 PM, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> > 
> > NOTE: I'm not sure where to document this property, as m25p80 is
> > 
> >       a simple DT device. Any hints please?
> > 
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > 
> >  Documentation/devicetree/bindings/mtd/m25p80.txt |   27
> >  ++++++++++++++++++ drivers/mtd/devices/m25p80.c                     |  
> >  32 +++++++++++++--------- 2 files changed, 46 insertions(+), 13
> >  deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> > 
> > V2: Add documentation for the DT property. (Thanks Rob Herring for
> > helping!)
> > 
> >     Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable
> >     via DT
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt
> > b/Documentation/devicetree/bindings/mtd/m25p80.txt new file mode 100644
> > index 0000000..e05d9b8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> > @@ -0,0 +1,27 @@
> > +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> > +
> > +Required properties:
> > +- #address-cells, #size-cells : Must be present if the device has
> > sub-nodes +  representing partitions.
> > +- compatible : Should be the name of the chip, see the "m25p_ids" table
> > in +               drivers/mtd/devices/m25p80.c
> 
> Two things wrong with this:

Damn, I just sent a V3 a minute ago. Please ignore that V3 then, since V4 will 
come of course, sorry about the noise. Let's discuss this properly.

> - Bindings are not Linux specific, so the docs should not be based on Linux.

Correct. Can you please advise how to formulate the "compatible" property then?

> - This doesn't follow the existing user which is "spansion,m25p80"

It doesn't, but the driver does support many other chips as well. I wasn't quite 
sure how to go about that either. Any help would be appreciated, I gotta admit 
I'm still a bit lost in all the devicetree stuff.

> Rob
[...]