devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Attila Kinali <attila-HB9FjVmMKa7tRgLqZ5aouw@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: specifying two conflicting configs
Date: Wed, 25 Jul 2012 13:48:01 +1000	[thread overview]
Message-ID: <20120725034801.GB23430@truffala.fritz.box> (raw)
In-Reply-To: <20120724113450.328c27430ebc4438d0048346-HB9FjVmMKa7tRgLqZ5aouw@public.gmane.org>

On Tue, Jul 24, 2012 at 11:34:50AM +0200, Attila Kinali wrote:
> Hi,
> 
> I have here an embedded system where i use a serial port as SD Card
> interface as well as SPI interface. I select what i want to use
> by setting a GPIO pin high or low.
> 
> Currently i'm using two different dts files, one that specifies the
> serial port as SD Card interface and one that specifies the serial
> port as SPI interface.
> 
> Now i would like to merge them into one file so that i can select
> which mode to use at runtime. The documentation gave me the impression
> that this should be possible, but i was not able to figure out how
> to do it.
> 
> Would someone be so kind and point me to the documentation/example
> i've missed?
> 
> The current configuration i use is either:
> 
> ssp0: ssp@80010000 {
>         compatible = "fsl,imx23-mmc";
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc0_8bit_pins_a &mmc1_pins_fixup>;
>         bus-width = <8>;
>         status = "okay";
> };
> 
> or:
> 
> ssp0: ssp@80010000 {
>         #address-cells = <1>;
>         #size-cells = <0>;
>         compatible = "fsl,imx23-spi";
>         fsl,ssp-dma-channel = <1>;
>         pinctrl-names = "default";
>         pinctrl-0 = <&spi_pins_a>;
>         status = "okay";
> 
> };

So, Mitch may have better insights here, but my inclination would be
to do something like this:

ssp-mux@80010000 {
	#address-cells = <1>;
	#size-cells = <0>;
	compatible = "yourvendor,ssp-mux";
	control-line = <&gpio 17>;
	ranges = <0x0 0x80010000>;

	ssp-mmc@0 {
		  compatible = "fsl,imx23-mmc";
		  /* ... */
		  status = "okay";
	};

	ssp-spi@1 {
		  compatible = "fsl,imx23-spi";
		  /* ... */
		  status = "disabled";
	};
};

ranges would need tweaking depending on #size-cells of the parent and
the existing node reg properties, which you don't show.

A hackier, but possibly simpler alternative would be to simply include
both nodes, but have the one that's active by default marked status =
"okay" and the other marked status = "disabled".  Platform specific
knowledge would then me needed to know that with the right gpio magic
the original one can be disabled and the other enabled.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  parent reply	other threads:[~2012-07-25  3:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24  9:34 specifying two conflicting configs Attila Kinali
     [not found] ` <20120724113450.328c27430ebc4438d0048346-HB9FjVmMKa7tRgLqZ5aouw@public.gmane.org>
2012-07-25  3:48   ` David Gibson [this message]
     [not found]     ` <20120725034801.GB23430-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-07-26  0:53       ` Mitch Bradley
2012-07-27  3:05       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120725034801.GB23430@truffala.fritz.box \
    --to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
    --cc=attila-HB9FjVmMKa7tRgLqZ5aouw@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).