devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Aggrwal Poonam-B10812 <B10812-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "pavel-ynQEQJNshbs@public.gmane.org"
	<pavel-ynQEQJNshbs@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>
Subject: Re: Forcing PIO mode instead of DMA via DT property
Date: Mon, 30 Jul 2012 16:00:44 +0200	[thread overview]
Message-ID: <201207301600.45000.marex@denx.de> (raw)
In-Reply-To: <ACB6D0C0104CFF42A45A5D82A0DD4F3D079B7AA7-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>

Dear Aggrwal Poonam-B10812,

[...]

> > > > We just had such a situation, where PIO had to be used on a specific
> > > > bus, because due to a hardware problem (board design error) DMA
> > > > would crash the system.  Yet the same driver/kernel would work fine
> > > > with DMA on other buses / boards.  OK, this was on x86, so DT would
> > > > not have helped, but I think a bus-specific property of being able
> > > > to do DMA (or not) might indeed make sense for the DT.
> > > 
> > > In that case probably we can use QUIRKS like broken-dma. I see this in
> > > the sdhc driver in Linux. On P2020 chip(rev 1.0) of FSL DMA was broken
> > > so we used this to force PIO.
> > 
> > Do you please happen to have any sample of such DT binding for reference?
> 
> Sorry cannot find the DT bindings in upstream, probably this issue was not
> there in P2020 Rev2.0 hence so. I can cite a node from FSL old SDK
> sdhci@2e000 {
> 			compatible = "fsl,p2020-esdhc", "fsl,esdhc";
> 			reg = <0x2e000 0x1000>;
> 			interrupts = <72 0x2>;
> 			interrupt-parent = <&mpic>;
> 			fsl,sdhci-adjust-timeout;
> 			/* Filled in by U-Boot */
> 			clock-frequency = <0>;
> 		};
> 
> 
> 
> You can look at drivers/mmc/host/sdhci-of-esdhc.c which handles various
> quirks.

Ok, so you suggest we add such a property or what is the conclusion please?

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-07-30 14:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 21:28 Forcing PIO mode instead of DMA via DT property Marek Vasut
     [not found] ` <201207222328.27008.marex-ynQEQJNshbs@public.gmane.org>
2012-07-23  3:25   ` Aggrwal Poonam-B10812
     [not found]     ` <ACB6D0C0104CFF42A45A5D82A0DD4F3D079B4DAE-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-07-23  3:31       ` Marek Vasut
     [not found]         ` <201207230531.02305.marex-ynQEQJNshbs@public.gmane.org>
2012-07-23  3:49           ` Varun Wadekar
2012-07-23  4:38           ` Aggrwal Poonam-B10812
2012-07-23  5:47       ` Wolfgang Denk
     [not found]         ` <20120723054758.C622C200263-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2012-07-24  1:56           ` Aggrwal Poonam-B10812
     [not found]             ` <ACB6D0C0104CFF42A45A5D82A0DD4F3D079B6B36-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-07-24  4:17               ` Marek Vasut
     [not found]                 ` <201207240617.31565.marex-ynQEQJNshbs@public.gmane.org>
2012-07-24 14:49                   ` Aggrwal Poonam-B10812
     [not found]                     ` <ACB6D0C0104CFF42A45A5D82A0DD4F3D079B7AA7-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-07-30 14:00                       ` Marek Vasut [this message]
2012-07-24 13:19   ` Arnd Bergmann
     [not found]     ` <201207241319.45101.arnd-r2nGTMty4D4@public.gmane.org>
2012-07-24 14:35       ` Wolfgang Denk
     [not found]         ` <20120724143533.080F5200247-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2012-07-24 14:55           ` Mitch Bradley
     [not found]             ` <500EB77B.6050105-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-07-24 14:59               ` Mis-wrapped text Mitch Bradley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207301600.45000.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=B10812-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=pavel-ynQEQJNshbs@public.gmane.org \
    --cc=wd-ynQEQJNshbs@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).