From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 2/4] PM / OPP: Initialize OPP table from device tree Date: Mon, 6 Aug 2012 11:19:19 +0800 Message-ID: <20120806031916.GC22302@S2101-09.ap.freescale.net> References: <1344179121-17738-1-git-send-email-shawn.guo@linaro.org> <1344179121-17738-3-git-send-email-shawn.guo@linaro.org> <501F30F8.1040105@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <501F30F8.1040105@gmail.com> Sender: cpufreq-owner@vger.kernel.org To: Rob Herring Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, Kevin Hilman , Nishanth Menon , Russell King - ARM Linux , Mike Turquette , devicetree-discuss@lists.ozlabs.org, Mark Brown , "Rafael J. Wysocki" , Shilimkar Santosh , Richard Zhao , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Sun, Aug 05, 2012 at 09:50:32PM -0500, Rob Herring wrote: > > +Properties: > > +- operating-points: An array of 3-tuples items, and each item consists > > 3 tuples? > It's the case of v1, and I forgot updating it. Thanks for spotting it. > > + of frequency and voltage like . > > + freq: clock frequency in kHz > > + vol: voltage in microvolt > > Although maybe 3 fields would be good for a flags field? I'm concerned > it's a pretty generic name and not very future proof. What about > transition times? Not sure how you would represent that as it probably > depends on which points you are changing between rather than a property > of the opp. > This is a binding for OPP, which does not define transition times. As for cpufreq, we only need to represent a possible maximum transition latency. The driver will ask regulator subsystem for voltage latency, while the clock latency is defined in DT. > I think this whole function can be written more concisely. Just iterate > over the property and avoid the intermediate array allocation. > I'm not sure about that, since directly iterating over the property means we have to take care of all these sanity checks done in API of_property_read_u32_array(). -- Regards, Shawn