From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap Date: Fri, 24 Aug 2012 10:28:09 +0800 Message-ID: <20120824022807.GA5822@shlinux2.ap.freescale.net> References: <1345619928-15446-1-git-send-email-b29396@freescale.com> <1345619928-15446-2-git-send-email-b29396@freescale.com> <20120822160241.GR7995@opensource.wolfsonmicro.com> <20120823072629.GG10057@shlinux2.ap.freescale.net> <20120823110647.GU7995@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120823110647.GU7995-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mark Brown Cc: Zhao Richard-B20223 , "linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "lrg-l0cyMroinI0@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, Aug 23, 2012 at 07:06:47PM +0800, Mark Brown wrote: > On Thu, Aug 23, 2012 at 03:26:30PM +0800, Dong Aisheng wrote: > > On Thu, Aug 23, 2012 at 12:02:41AM +0800, Mark Brown wrote: > > > > It'd be good to provide a way of retrieving the regmap so that drivers > > > for subsystems with generic regmap code could use the framework features > > > (regulator is one example that I just mentioned in my other mail). > > > Do you mean something like: > > regmap = syscon_regmap_dev_lookup(np, "fsl,anatop"); > > regmap_write(regmap, reg, val); > > > Then drivers can use generic regmap framework features rather than depend > > on what imx-syscon implemented, is that correct? > > Yes, this is mainly for cases where the subsystem has helper functions > that can work with regmap. Okay, then imx-syscon only implements regmap register mechanism and regmap lookup mechanism, for accessors, client driver can directly use the generic regmap API defined in include/linux/regmap.h. Then it looks to me the driver is more like a generic feature which may also be needed for other SoCs, IIRC, Tegra ahb and ux500 PRCMU, Do you think if we should implement it in a more generic way at first? e.g, drop 'imx-' prefix first. Linus, You're the first guy to raise the idea that we could implement a syscon framework to generic register access, what's your comment on this? Regards Dong Aisheng