From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register Date: Fri, 24 Aug 2012 10:29:47 +0800 Message-ID: <20120824022946.GB5822@shlinux2.ap.freescale.net> References: <1345619928-15446-1-git-send-email-b29396@freescale.com> <1345619928-15446-5-git-send-email-b29396@freescale.com> <20120822155953.GQ7995@opensource.wolfsonmicro.com> <20120823071503.GF10057@shlinux2.ap.freescale.net> <20120823111741.GX7995@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20120823111741.GX7995@opensource.wolfsonmicro.com> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linus.walleij@stericsson.com" , "s.hauer@pengutronix.de" , "shawn.guo@linaro.org" , "kernel@pengutronix.de" , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "sameo@linux.intel.com" , "lrg@ti.com" , Zhao Richard-B20223 , "devicetree-discuss@lists.ozlabs.org" , "swarren@wwwdotorg.org" List-Id: devicetree@vger.kernel.org On Thu, Aug 23, 2012 at 07:17:41PM +0800, Mark Brown wrote: > On Thu, Aug 23, 2012 at 03:15:04PM +0800, Dong Aisheng wrote: > > On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote: > > > > With the conversion to regmap it'd also be good to convert the driver to > > > use the regmap helper functions for enable and voltage operations if > > > possible. > > > The anatop-regulator driver only implements set_voltage_sel/get_voltage_sel > > which i have already converted, what do you mean others like > > 'for enable and voltage operations' i should also convert? > > Those operations should ideally be converted to use the generic regmap > implementation now the device uses regmap - regmap_get_voltage_sel_regmap > and so on. Okay, got it. Regards Dong Aisheng