From: Dong Aisheng <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Zhao Richard-B20223
<B20223-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org"
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org"
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"lrg-l0cyMroinI0@public.gmane.org"
<lrg-l0cyMroinI0@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register
Date: Tue, 28 Aug 2012 10:08:07 +0800 [thread overview]
Message-ID: <20120828020806.GE5822@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120827221532.GC2281@r65073-Latitude-D630>
On Tue, Aug 28, 2012 at 06:15:35AM +0800, Shawn Guo wrote:
....
> > + sreg->anatop = syscon_regmap_lookup_by_phandle(np, "fsl,anatop");
> > + if (IS_ERR(sreg->anatop))
> > + return PTR_ERR(sreg->anatop);
> > +
>
> All the anatop regulators are child nodes of anatop. It looks a little
> odd to use phandle there. of_get_parent should just works.
>
Yes, this is a special case.
It's also ok for me to use of_get_parent if you want.
Will update it.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-08-28 2:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 7:24 [PATCH v2 0/7] add syscon driver based on regmap for general registers access Dong Aisheng
[not found] ` <1346052285-4344-1-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-27 7:24 ` [PATCH v2 1/7] mfd: add syscon driver based on regmap Dong Aisheng
2012-08-27 22:08 ` Shawn Guo
2012-08-28 2:01 ` Dong Aisheng
2012-08-27 7:24 ` [PATCH v2 2/7] ARM: imx6q: add iomuxc gpr support into syscon Dong Aisheng
2012-08-27 7:24 ` [PATCH v2 3/7] ARM: imx6q: add anatop " Dong Aisheng
2012-08-27 7:24 ` [PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register Dong Aisheng
2012-08-27 22:15 ` Shawn Guo
2012-08-28 2:08 ` Dong Aisheng [this message]
2012-08-27 7:24 ` [PATCH v2 5/7] ARM: imx6q: convert to use syscon to access anatop registers Dong Aisheng
2012-08-28 3:23 ` Richard Zhao
2012-08-28 5:33 ` Dong Aisheng
2012-08-27 7:24 ` [PATCH v2 6/7] ARM: dts: imx6q: add simple-bus compatible string for anatop Dong Aisheng
2012-08-27 7:24 ` [PATCH v2 7/7] mfd: anatop-mfd: remove anatop driver Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828020806.GE5822@shlinux2.ap.freescale.net \
--to=b29396-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=B20223-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).