devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, mkl@pengutronix.de,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca
Subject: Re: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone
Date: Thu, 30 Aug 2012 13:35:06 -0700	[thread overview]
Message-ID: <20120830203505.GB1303@atomide.com> (raw)
In-Reply-To: <1346141454-18786-3-git-send-email-anilkumar@ti.com>

* AnilKumar Ch <anilkumar@ti.com> [120828 01:11]:
> Adds GPIO pinctrl nodes to am3358_pinmux master node to control
> user leds (USR0, USR1, USR2 and USR3) present on BeagleBone.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  arch/arm/boot/dts/am335x-bone.dts |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
> index a7906cb..58f5042 100644
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -18,6 +18,20 @@
>  		reg = <0x80000000 0x10000000>; /* 256 MB */
>  	};
>  
> +	am3358_pinmux: pinmux@44E10800 {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&userled_pins>;
> +
> +		userled_pins: pinmux_userled_pins {
> +			pinctrl-single,pins = <
> +				0x54 0x7	/* gpmc_a5.gpio1_21, OUTPUT | MODE7 */
> +				0x58 0x17	/* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */
> +				0x5C 0x7	/* gpmc_a7.gpio1_23, OUTPUT | MODE7 */
> +				0x60 0x17	/* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */
> +			>;
> +		};
> +	};
> +

Looks like this patch should also claim these pins by the led driver.
Then the led driver should just do pinctrl_get_select_default(&pdev->dev)
in it's probe function to set the pins.

Tony


  reply	other threads:[~2012-08-30 20:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  8:10 [PATCH v4 0/3] Add device tree data for AM33XX devices AnilKumar Ch
     [not found] ` <1346141454-18786-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-08-28  8:10   ` [PATCH RESEND v4 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data AnilKumar Ch
2012-08-30 20:32     ` Tony Lindgren
     [not found]       ` <20120830203234.GA1303-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-08-31  6:17         ` Vaibhav Hiremath
2012-08-28  8:10   ` [PATCH v4 3/3] arm/dts: AM33XX: Add D_CAN " AnilKumar Ch
2012-08-30 20:35     ` Tony Lindgren
2012-08-28  8:10 ` [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone AnilKumar Ch
2012-08-30 20:35   ` Tony Lindgren [this message]
2012-08-31 15:53     ` Koen Kooi
2012-09-01  7:01       ` AnilKumar, Chimata
2012-09-01 10:47         ` Koen Kooi
     [not found]           ` <6D25CE9A-4FA3-4F1E-9549-6A512F2FDCEC-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>
2012-09-01 12:51             ` AnilKumar, Chimata
2012-09-03 12:25           ` AnilKumar, Chimata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830203505.GB1303@atomide.com \
    --to=tony@atomide.com \
    --cc=anilkumar@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).