From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone Date: Thu, 30 Aug 2012 13:35:06 -0700 Message-ID: <20120830203505.GB1303@atomide.com> References: <1346141454-18786-1-git-send-email-anilkumar@ti.com> <1346141454-18786-3-git-send-email-anilkumar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1346141454-18786-3-git-send-email-anilkumar@ti.com> Sender: linux-omap-owner@vger.kernel.org To: AnilKumar Ch Cc: wg@grandegger.com, mkl@pengutronix.de, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca List-Id: devicetree@vger.kernel.org * AnilKumar Ch [120828 01:11]: > Adds GPIO pinctrl nodes to am3358_pinmux master node to control > user leds (USR0, USR1, USR2 and USR3) present on BeagleBone. > > Signed-off-by: AnilKumar Ch > --- > arch/arm/boot/dts/am335x-bone.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts > index a7906cb..58f5042 100644 > --- a/arch/arm/boot/dts/am335x-bone.dts > +++ b/arch/arm/boot/dts/am335x-bone.dts > @@ -18,6 +18,20 @@ > reg = <0x80000000 0x10000000>; /* 256 MB */ > }; > > + am3358_pinmux: pinmux@44E10800 { > + pinctrl-names = "default"; > + pinctrl-0 = <&userled_pins>; > + > + userled_pins: pinmux_userled_pins { > + pinctrl-single,pins = < > + 0x54 0x7 /* gpmc_a5.gpio1_21, OUTPUT | MODE7 */ > + 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */ > + 0x5C 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */ > + 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */ > + >; > + }; > + }; > + Looks like this patch should also claim these pins by the led driver. Then the led driver should just do pinctrl_get_select_default(&pdev->dev) in it's probe function to set the pins. Tony