devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: ludovic.desroches@atmel.com
Cc: devicetree-discuss@lists.ozlabs.org, n.voss@weinmann.de,
	nicolas.ferre@atmel.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/8] i2c: at91: use an id table for SoC dependent parameters
Date: Fri, 31 Aug 2012 16:29:44 +0200	[thread overview]
Message-ID: <20120831142944.GA23867@game.jcrosoft.org> (raw)
In-Reply-To: <1346404884-18451-4-git-send-email-ludovic.desroches@atmel.com>

On 11:21 Fri 31 Aug     , ludovic.desroches@atmel.com wrote:
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
> 
> Use the id_table to store configuration structures which are depending on
> SoC.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>  arch/arm/mach-at91/at91rm9200.c          |  2 +-
>  arch/arm/mach-at91/at91rm9200_devices.c  | 11 +----
>  arch/arm/mach-at91/at91sam9260.c         |  3 +-
>  arch/arm/mach-at91/at91sam9260_devices.c |  8 ++-
>  arch/arm/mach-at91/at91sam9261.c         |  3 +-
>  arch/arm/mach-at91/at91sam9261_devices.c | 17 +++----
>  arch/arm/mach-at91/at91sam9263.c         |  2 +-
>  arch/arm/mach-at91/at91sam9263_devices.c |  2 +-
>  arch/arm/mach-at91/at91sam9g45.c         |  4 +-
>  arch/arm/mach-at91/at91sam9g45_devices.c |  4 +-
>  arch/arm/mach-at91/at91sam9rl.c          |  4 +-
>  arch/arm/mach-at91/at91sam9rl_devices.c  |  2 +-
>  drivers/i2c/busses/i2c-at91.c            | 85 +++++++++++++++++++++++++-------
>  13 files changed, 95 insertions(+), 52 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
> index f2112f9..0bc91e5 100644
> --- a/arch/arm/mach-at91/at91rm9200.c
> +++ b/arch/arm/mach-at91/at91rm9200.c
> @@ -187,7 +187,7 @@ static struct clk_lookup periph_clocks_lookups[] = {
>  	CLKDEV_CON_DEV_ID("pclk", "ssc.0", &ssc0_clk),
>  	CLKDEV_CON_DEV_ID("pclk", "ssc.1", &ssc1_clk),
>  	CLKDEV_CON_DEV_ID("pclk", "ssc.2", &ssc2_clk),
> -	CLKDEV_CON_DEV_ID(NULL, "at91_i2c", &twi_clk),
> +	CLKDEV_CON_DEV_ID(NULL, "at91rm9200_i2c", &twi_clk),
use i2c-xxx as on other drivers

and I do not like to have platform_device_id

as we need to touch the driver to add a new soc

please use platform data

Best Regards,
J.

  reply	other threads:[~2012-08-31 14:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31  9:21 [PATCH 0/8] i2c: at91: cleanup and dt support ludovic.desroches
2012-08-31  9:21 ` [PATCH 1/8] i2c: at91: use managed resources ludovic.desroches
     [not found]   ` <1346404884-18451-2-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:52     ` Voss, Nikolaus
     [not found] ` <1346404884-18451-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-08-31  9:21   ` [PATCH 2/8] i2c: at91: add warning about transmission issues for some devices ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1346404884-18451-3-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:54       ` Voss, Nikolaus
2012-08-31  9:21   ` [PATCH 4/8] ARM: at91: do not configure at91sam9g10 twi pio as open-drain ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1346404884-18451-5-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:57       ` Voss, Nikolaus
2012-09-06  4:57       ` Warner Losh
2012-08-31  9:23   ` ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
2012-08-31  9:23   ` [PATCH 5/8] i2c: at91: add dt support to i2c-at91 ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1346405029-18539-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:58       ` Voss, Nikolaus
2012-08-31  9:24   ` [PATCH 6/8] ARM: at91: add clocks for I2C DT entries ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1346405058-18580-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:58       ` Voss, Nikolaus
2012-08-31  9:24   ` [PATCH 8/8] ARM: dts: add twi nodes for atmel boards ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
2012-08-31 14:42     ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]       ` <20120831144228.GC23867-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-08-31 15:07         ` Nicolas Ferre
     [not found]           ` <5040D31E.8040306-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-01  9:12             ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-03  7:55   ` [PATCH 0/8] i2c: at91: cleanup and dt support Nicolas Ferre
2012-08-31  9:21 ` [PATCH 3/8] i2c: at91: use an id table for SoC dependent parameters ludovic.desroches
2012-08-31 14:29   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
     [not found]     ` <20120831142944.GA23867-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-08-31 14:51       ` Nicolas Ferre
     [not found]         ` <5040CF80.8060201-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-08-31 20:47           ` Sylwester Nawrocki
     [not found]             ` <504122D3.70507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-01  9:10               ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]                 ` <20120901091054.GA17540-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-09-02 17:21                   ` Sylwester Nawrocki
     [not found]                     ` <504395B1.2040203-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-06  4:54                       ` Warner Losh
2012-09-03  6:16                   ` Voss, Nikolaus
2012-09-03  7:24                   ` ludovic.desroches
     [not found]                     ` <50445B11.5050601-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  7:51                       ` Nicolas Ferre
     [not found]   ` <1346404884-18451-4-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-03  5:55     ` Voss, Nikolaus
2012-08-31  9:24 ` [PATCH 7/8] ARM: dts: add twi nodes for atmel SOCs ludovic.desroches
2012-08-31 14:41   ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]     ` <20120831144105.GB23867-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-08-31 14:46       ` ludovic.desroches
2012-08-31 14:56       ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831142944.GA23867@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=n.voss@weinmann.de \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).