Re: [PATCH V3] dtc: Add ability to delete nodes and properties

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

On Tue, Aug 07, 2012 at 10:50:15PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> dtc currently allows the contents of properties to be changed, and the
> contents of nodes to be added to. There are situations where removing
> properties or nodes may be useful. This change implements the following
> syntax to do that:
> 
>     / {
>         /delete-property/ propname;
>         /delete-node/ nodename;
>     };
> 
> or:
> 
>     /delete-node/ &noderef;
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Sorry, I've taken forever to look at this.  I've had other things to
work on, plus I've second guessed myself on this stuff about a million
times.

I think I finally did pin down the chief thing that was making me
antsy about the whole thing, which is that it introduces an order
dependency where none existed before.  We already had the order
dependency between tree fragments in the "stack of overlays" model,
but we didn't previously have a dependency on the order of
declarations within one fragment.

With that in mind, there are some details I would like to see cleaned
up, mostly in the precise semantics of when duplicate names are
detected.  But I'm happy enough to do that cleanup after the main
patch is merged.

Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson