From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register Date: Tue, 4 Sep 2012 19:27:04 +0800 Message-ID: <20120904112703.GA13046@shlinux2.ap.freescale.net> References: <1346728811-25788-1-git-send-email-b29396@freescale.com> <1346728811-25788-4-git-send-email-b29396@freescale.com> <20120904113429.GK2362@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20120904113429.GK2362@S2101-09.ap.freescale.net> Sender: linux-kernel-owner@vger.kernel.org To: Shawn Guo Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linus.walleij@stericsson.com" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "sameo@linux.intel.com" , "lrg@ti.com" , "broonie@opensource.wolfsonmicro.com" , Zhao Richard-B20223 , "devicetree-discuss@lists.ozlabs.org" , "swarren@wwwdotorg.org" List-Id: devicetree@vger.kernel.org On Tue, Sep 04, 2012 at 07:34:32PM +0800, Shawn Guo wrote: > On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote: > > + > > + anatop_np = of_get_parent(np); > > + if (!anatop_np) > > + return -ENODEV; > > + sreg->anatop = syscon_node_to_regmap(anatop_np); > > + if (IS_ERR(sreg->anatop)) > > + return PTR_ERR(sreg->anatop); > > + > With of_node_put moved out from syscon_node_to_regmap, shouldn't > we put anatop_np here then? > When i sent it out, i found i missed it... Should be more care... Regards Dong Aisheng