From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v5 1/5] arm/dts: AM33XX: Add basic pinctrl device tree data Date: Wed, 5 Sep 2012 16:32:05 -0700 Message-ID: <20120905233205.GO1303@atomide.com> References: <1346405361-29711-1-git-send-email-anilkumar@ti.com> <1346405361-29711-2-git-send-email-anilkumar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1346405361-29711-2-git-send-email-anilkumar@ti.com> Sender: linux-omap-owner@vger.kernel.org To: AnilKumar Ch Cc: wg@grandegger.com, mkl@pengutronix.de, bryan.wu@canonical.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca List-Id: devicetree@vger.kernel.org * AnilKumar Ch [120831 02:30]: > Adds basic pinctrl device tree data for AM33XX family of devices. > This patch is based on the pinctrl-single driver. > > Signed-off-by: AnilKumar Ch > --- > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index be43511..bf5f713 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -40,6 +40,15 @@ > }; > }; > > + am3358_pinmux: pinmux@44e10800 { > + compatible = "pinctrl-single"; > + reg = <0x44e10800 0x0238>; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-single,register-width = <32>; > + pinctrl-single,function-mask = <0x7f>; > + }; > + Is this controller the same for all am33xx? If so, please use am33xx_pinmux naming. Note that some padconf registers may not be listed for all the variants, but the registers may still be there for all the variants. So a generic entry is a better choice here as otherwise you'l need to include am33xx.dtsi into am3358.dtsi. Regards, Tony