From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v5 2/4] pwm_backlight: use power sequences Date: Fri, 7 Sep 2012 16:29:03 +0800 Message-ID: <20120907082835.GC17749@opensource.wolfsonmicro.com> References: <1346412846-17102-1-git-send-email-acourbot@nvidia.com> <1346412846-17102-3-git-send-email-acourbot@nvidia.com> <50478B07.4080708@wwwdotorg.org> <2360396.YKI4EihrfI@percival> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <2360396.YKI4EihrfI@percival> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Alex Courbot Cc: "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Anton Vorontsov , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , David Woodhouse , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Sep 07, 2012 at 05:28:17PM +0900, Alex Courbot wrote: > We could make power sequences an option of its own and add #ifdefs to drivers > that use it to lift this ambiguity, but I like the transparency of the current > way. It also seems hard (illegal?) to get rid of the legacy DT interface. If you're doing this I'd suggest using stubs rather than ifdefs in the users, otherwise it's just going to cause lots of annoyance from randconfig build. Is the code likely to big enough to worry about, though?