From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH V2 1/2] hwmon: Add devicetree bindings to gpio-fan Date: Mon, 10 Sep 2012 17:28:14 +0200 Message-ID: <20120910152814.GA6050@lunn.ch> References: <1347035675-23907-1-git-send-email-jm@lentin.co.uk> <1347285112-13542-1-git-send-email-jm@lentin.co.uk> <1347285112-13542-2-git-send-email-jm@lentin.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1347285112-13542-2-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jamie Lentin Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jean Delvare , Guenter Roeck List-Id: devicetree@vger.kernel.org On Mon, Sep 10, 2012 at 02:51:51PM +0100, Jamie Lentin wrote: > Allow a gpio-fan to be defined in devicetree, see binding documentation > for details. > > Changes since V1:- > * Don't hide return codes [Guenter Roeck] > * Remove typecast noise [Guenter Roeck] > * Use of_find_property instead of counting u32s [Guenter Roeck] > * Don't count GPIOs twice [Andrew Lunn] > * Use of_prop_next_u32 to get records in a more obvious fashion > * Use CONFIG_OF_GPIO instead of CONFIG_OF > * Apply __devinitdata to of_gpio_fan_match [Andrew Lunn] > > Signed-off-by: Jamie Lentin > --- > .../devicetree/bindings/gpio/gpio-fan.txt | 25 +++++ > drivers/hwmon/gpio-fan.c | 116 ++++++++++++++++++++ > 2 files changed, 141 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-fan.txt Hi Jamie Thanks for addressing all the issues raised. However... Anything before the --- ends up in the changelog entry. Anything afterwards does not. The changes you made to address review comments is not something for the changelog, so Changes since V1:- should be after the --- . There is more detail in Documentation/SubmittingPatches Andrew