From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 2/2] dtc: cpp co-existence: add support for #line directives
Date: Wed, 26 Sep 2012 14:34:59 +1000 [thread overview]
Message-ID: <20120926043459.GD31993@truffula.fritz.box> (raw)
In-Reply-To: <1348527077-27471-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Mon, Sep 24, 2012 at 04:51:17PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Line control directives of the following formats are supported:
> #line LINE "FILE"
> # LINE FILE [FLAGS]
>
> This allows dtc to consume the output of pre-processors, and to provide
> error messages that refer to the original filename, including taking
> into account any #include directives that the pre-processor may have
> performed.
I like the idea of handling line directives, whichever way we go with
the other cpp-related proposals. The fact that these are
distinguished from a propnodename beginning with # only by the
following digits is more subtle than I'd ideally like, but I think
it's wirth it.
The only thing I would like to see change is to only recognize line
directives at the beginning of the line (in fact, preferably in column
0 only). Unfortunately that is going to mean some mucky flex work,
including a new start state, I expect.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-09-26 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 22:51 [PATCH 0/2] dtc: cpp co-existence Stephen Warren
[not found] ` <1348527077-27471-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-24 22:51 ` [PATCH 1/2] dtc: cpp co-existence: allow names starting with # to be escaped Stephen Warren
2012-09-24 22:51 ` [PATCH 2/2] dtc: cpp co-existence: add support for #line directives Stephen Warren
[not found] ` <1348527077-27471-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-26 4:34 ` David Gibson [this message]
[not found] ` <20120926043459.GD31993-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-09-26 5:58 ` Stephen Warren
[not found] ` <50629968.9040800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-26 8:53 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926043459.GD31993@truffula.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).