From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule Date: Sat, 29 Sep 2012 22:08:28 +0200 Message-ID: <20120929200828.GD31527@game.jcrosoft.org> References: <1348860731-20868-1-git-send-email-swarren@wwwdotorg.org> <1348860731-20868-2-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1348860731-20868-2-git-send-email-swarren@wwwdotorg.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Warren Cc: David Gibson , Jon Loeliger , Grant Likely , Rob Herring , Scott Wood , Mark Brown , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Stephen Warren List-Id: devicetree@vger.kernel.org On 13:32 Fri 28 Sep , Stephen Warren wrote: > From: Stephen Warren > > All architectures that use cmd_dtc do so in the same way. Move the build > rule to a central location to avoid duplication. > > Signed-off-by: Stephen Warren > --- > Jean-Christophe, > Moving the build rule to Makefile.lib rather than Makefile.build seems > reasonable to me; the dtc-related logic is already in Makefile.lib, and > for features where cmd_* is defined in Makefile.lib, the associated > build rule is also defined there. I see no reason for this patch series > to move all the dtc-related logic into Makefile.build. build rules are in Makefile.build c to o , s to o etc... so put it in Makefile.build is the correct place ditto fot the dtc cmd Best Regards, J.