Re: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree

Re: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree

[Andrew Lunn]

> Date: Tue,  2 Oct 2012 18:01:00 +0200
> From: Fabio Porcedda <fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> To: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
>         linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nicolas Ferre
>         <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>, Jean-Christophe PLAGNIOL-VILLARD
>         <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>, Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>
> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> Subject: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree
>         support
> Message-ID:
>         <1349193662-23482-2-git-send-email-fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Tested on an at91sam9260 board (evk-pro3)
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> +++ b/drivers/watchdog/at91sam9_wdt.c
> @@ -32,6 +32,7 @@
>  #include <linux/timer.h>
>  #include <linux/bitops.h>
>  #include <linux/uaccess.h>
> +#include <linux/of.h>
> 
>  #include "at91sam9_wdt.h"
> 
> > @@ -302,11 +303,21 @@ static int __exit at91wdt_remove(struct platform_device *pdev)
>         return res;
>  }
> 
> +#if defined(CONFIG_OF)
> +static const struct of_device_id at91_wdt_dt_ids[] = {
> +       { .compatible = "atmel,at91sam9260-wdt" },
> +       { /* sentinel */ }
> +};

Hi Fabio

You are missing __devinitdata.

    Andrew

Re: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree

[Fabio Porcedda]

On Tue, Oct 2, 2012 at 10:07 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> Date: Tue,  2 Oct 2012 18:01:00 +0200
>> From: Fabio Porcedda <fabio.porcedda@gmail.com>
>> To: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org,
>>         linux-arm-kernel@lists.infradead.org, Nicolas Ferre
>>         <nicolas.ferre@atmel.com>, Jean-Christophe PLAGNIOL-VILLARD
>>         <plagnioj@jcrosoft.com>, Andrew Victor <linux@maxim.org.za>
>> Cc: devicetree-discuss@lists.ozlabs.org
>> Subject: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree
>>         support
>> Message-ID:
>>         <1349193662-23482-2-git-send-email-fabio.porcedda@gmail.com>
>>
>> Tested on an at91sam9260 board (evk-pro3)
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> +++ b/drivers/watchdog/at91sam9_wdt.c
>> @@ -32,6 +32,7 @@
>>  #include <linux/timer.h>
>>  #include <linux/bitops.h>
>>  #include <linux/uaccess.h>
>> +#include <linux/of.h>
>>
>>  #include "at91sam9_wdt.h"
>>
>> > @@ -302,11 +303,21 @@ static int __exit at91wdt_remove(struct platform_device *pdev)
>>         return res;
>>  }
>>
>> +#if defined(CONFIG_OF)
>> +static const struct of_device_id at91_wdt_dt_ids[] = {
>> +       { .compatible = "atmel,at91sam9260-wdt" },
>> +       { /* sentinel */ }
>> +};
>
> Hi Fabio
>
> You are missing __devinitdata.

Thank you, Andrew.
I'll add __initconst, because it's const and use platform_driver_probe.

Best regards
-- 
Fabio Porcedda