From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH 1/1] mtd: st fsmc_nand: pass the ale and cmd resource via resource Date: Fri, 5 Oct 2012 16:20:04 +0200 Message-ID: <20121005142004.GB12462@game.jcrosoft.org> References: <1349356456-13371-1-git-send-email-plagnioj@jcrosoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Linus Walleij Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 14:49 Fri 05 Oct , Linus Walleij wrote: > > On Thu, Oct 4, 2012 at 3:14 PM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > > Do not use the platform_data to pass resource and be smart in the drivers. > > Just pass it via resource > > > > Switch to devm_request_and_ioremap at the sametime > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Linus Walleij > > Cc: Vipin Kumar > > Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > This is much better. Actually I was confused by these offsets recently... > Acked-by: Linus Walleij > > My patch to convert the Nomadik to the FSMC driver will collide with this, > but I can sure fix it up as we run into it, no big deal. ha you did it too I'll give it a try Best Regards, J.